feat: implement dokku_domains task#123
Merged
josegonzalez merged 2 commits intomasterfrom Apr 25, 2026
Merged
Conversation
Adds a new DomainsTask supporting four states compatible with the upstream ansible-dokku dokku_domains module: - present: idempotently add domains (only adds missing ones) - absent: idempotently remove domains (only removes existing ones) - set: replace all domains unconditionally - clear: remove all domains unconditionally Supports both per-app and global domain operations via the global flag. Includes unit tests, YAML parsing tests, integration tests, and documentation.
Adds a getReportedDomains helper that queries dokku domains:report to verify the actual domain state after each operation: add, remove, set, and clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dokku_domainstask with four states:present(idempotent add),absent(idempotent remove),set(replace all), andclear(remove all)dokku_domainsmoduleStateSetandStateClearconstants to the state systemCloses #8