Compatibility with new section editing in DokuWiki Greebo, fix #223#224
Merged
Compatibility with new section editing in DokuWiki Greebo, fix #223#224
Conversation
lpaulsen93
approved these changes
Apr 17, 2018
Member
There was a problem hiding this comment.
Looks good and a simple test (without @splitbrain's workaround in the DokuWiki core) was successful. That means without the changes I saw problems with section edit buttons on included pages and with the changes of this PR applied problems were gone.
Member
|
Although the question is if we merge this PR or rely on the workaround in the core? |
Member
Author
|
The workaround in the core still triggers an error message, the changes in this PR are necessary to silence them - therefore I will merge them. |
Member
|
👍 |
Closed
issmirnov
added a commit
to issmirnov-forks/plugin-include
that referenced
this pull request
Apr 27, 2018
Resolves errors on Greebo (dokufreaks#224) Merge branch 'master' of https://github.com/dokufreaks/plugin-include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic compatibility fix. It would be nice if the edit button of the include plugin (for the whole included page) could also set the
hidof the first header but this is not easily possible as thathidis not available globally (for this the code design would need to be changed). Further, the code block count won't be correct when multiple pages are included. This would probably need to be patched when the actual buttons are generated in the action plugin. For this, the actual code block count would need to be determined when scanning the instructions of the page to include (in particular when only a single section is included). I haven't implemented that yet and would move this to a new issue once this has been merged as I think basic compatibility is more important than correct code block counts.