Fix replacer error on patches with empty Runs#2875
Merged
dolanmiu merged 7 commits intodolanmiu:masterfrom Dec 3, 2024
Merged
Conversation
Since `Run` already has a option for instantiating a `Text` element, we don't need to push children here.
SebKranz
commented
Dec 2, 2024
| describe("replacer", () => { | ||
| describe("replacer", () => { | ||
| it("should throw an error if nothing is added", () => { | ||
| it("should return { didFindOccurrence: false } if nothing is added", () => { |
Contributor
Author
There was a problem hiding this comment.
I forgot to change the description in PR #2856.
SebKranz
force-pushed
the
fix_empty_text_runs
branch
from
ff0f43e to
13fee3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2875 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 286 286
Lines 14366 14359 -7
Branches 1400 1400
=========================================
- Hits 14366 14359 -7 ☔ View full report in Codecov by Sentry. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in #2855, which occurs because of two minor issues:
TextRun("")andTextRun({ text: "" })counterintuitively didn't do the same thing. One creates an innerTextand one doesn't. This PR changesTextRun(""), so that both always create the inner Text.replacerdidn't handle patches with emptyRuns. This is also fixed by this PR.