feat(table-of-contents): cached data#3319
Conversation
99a9a5a to
fb7c0ba
Compare
1e6c09f to
7bb778c
Compare
7bb778c to
f5668e6
Compare
f5668e6 to
22876f9
Compare
|
For some reason, the level margin doesn't work as expected, not sure why |
This commit can be squashed with the previous one if necessary
6ebc5e7 to
09fb2d0
Compare
|
I am not sure why test is failing. I am pretty sure I am covering all code paths in the code that I have added. Also what is wrong with the CSpell? |
|
Can you give me write permissions for this repo so I can fix the cspell, test and resolve conflicts? |
|
I have tried to invite you, let me know if it worked |
# Conflicts: # src/file/table-of-contents/table-of-contents.spec.ts # src/file/table-of-contents/table-of-contents.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 305 305
Lines 9435 9510 +75
Branches 1499 1517 +18
=========================================
+ Hits 9435 9510 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All worked, thanks! Updated branch. Looks good. I will update the name of it. |
|
regarding cachedContent I was trying to be consistent in regards to I have renamed it to cachedEntries to allow for other elements such as a cached title. |
This pull request is a draft as I would like some feedback for the direction.
I think it would be beneficial to be able to provide cached data for the table of contents, just like other fields.
Does the
ToCEntrytype make sense, should it be defined elsewhere? Or should it be something else entirely?Does other properties also influence the output?
TODO: