Match and link gr_adventure_final.cpp#95
Conversation
Report for RSBE01_02 (70a37bd - bdcb76e)📈 Matched code: 1.08% (+0.01%, +832 bytes) ✅ 5 new matches
📈 1 improvement in an unmatched item
|
| "cflags": cflags_rel, | ||
| "host": False, | ||
| "objects": [ | ||
| Object(Matching, "mo_adv_stage/gr_adventure_final.cpp"), |
There was a problem hiding this comment.
There may be something wrong with CI, becuase the report says .data and .rodata are not fully matched, yet the file is marked Matching. Are these sections not showing 100% in objdiff?
There was a problem hiding this comment.
how do I remove the duplicate __RTTI__10grYakumono and similar data?
There was a problem hiding this comment.
It's not necessarily wrong for RTTI and vtables to be duplicated across RELs; it just means all the virtuals are defined in the class definition. As long as you've labeled them correctly in sora_adv_stage/symbols.txt, it's not a problem.
b8a201e to
a1460b1
Compare
fix getTeamYakumono symbol
This reverts commit 6b7751d.
No description provided.