Skip to content

Match and link gr_adventure_final.cpp#95

Merged
mparisi20 merged 3 commits intodoldecomp:mainfrom
MarioLover63:gr_adventure_final
Mar 12, 2026
Merged

Match and link gr_adventure_final.cpp#95
mparisi20 merged 3 commits intodoldecomp:mainfrom
MarioLover63:gr_adventure_final

Conversation

@MarioLover63
Copy link
Contributor

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Mar 12, 2026

Report for RSBE01_02 (70a37bd - bdcb76e)

📈 Matched code: 1.08% (+0.01%, +832 bytes)
📈 Linked code: 0.93% (+0.01%, +832 bytes)
📈 Matched data: 14.57% (+0.00%, +12 bytes)
📈 Linked data: 14.84% (+0.01%, +556 bytes)

✅ 5 new matches
Unit Item Bytes Before After
sora_adv_stage/mo_adv_stage/gr_adventure_final grAdventureFinal::updateEff() +504 0.00% 100.00%
sora_adv_stage/mo_adv_stage/gr_adventure_final grAdventureFinal::create(int, const char*, const char*) +224 0.00% 100.00%
sora_adv_stage/mo_adv_stage/gr_adventure_final grAdventureFinal::~grAdventureFinal() +88 0.00% 100.00%
sora_adv_stage/mo_adv_stage/gr_adventure_final grAdventureFinal::update(float) +16 0.00% 100.00%
sora_adv_stage/mo_adv_stage/gr_adventure_final .rodata +12 0.00% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
sora_adv_stage/mo_adv_stage/gr_adventure_final .data +483 0.00% 88.89%

"cflags": cflags_rel,
"host": False,
"objects": [
Object(Matching, "mo_adv_stage/gr_adventure_final.cpp"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be something wrong with CI, becuase the report says .data and .rodata are not fully matched, yet the file is marked Matching. Are these sections not showing 100% in objdiff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I remove the duplicate __RTTI__10grYakumono and similar data?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessarily wrong for RTTI and vtables to be duplicated across RELs; it just means all the virtuals are defined in the class definition. As long as you've labeled them correctly in sora_adv_stage/symbols.txt, it's not a problem.

fix getTeamYakumono symbol
This reverts commit 6b7751d.
@mparisi20 mparisi20 merged commit c678621 into doldecomp:main Mar 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants