MarNameRefGen

[hyblocker]

mostly decomp the MarNameRefGen classes; can't be 100% matching yet because we still need to decompile the classes they reference

[decomp-dev]

Report for GMSJ01 (5e83a23 - 3611de2)

📈 Matched code: 28.48% (+0.05%, +1736 bytes)
📈 Matched data: 31.22% (+0.01%, +48 bytes)

✅ 16 new matches

Unit	Item	Bytes	Before	After
mario/System/MarNameRefGen_MapObj	TFenceWater::~TFenceWater()	+156	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TItem::~TItem()	+156	0.00%	100.00%
mario/System/MarNameRefGen_Enemy	TWalkerEnemy::~TWalkerEnemy()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TMapObjChangeStage::~TMapObjChangeStage()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	THideObjBase::~THideObjBase()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TFence::~TFence()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TSandLeaf::~TSandLeaf()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TMapObjGeneral::~TMapObjGeneral()	+132	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TJuiceBlock::~TJuiceBlock()	+132	0.00%	100.00%
mario/System/MarNameRefGen_Enemy	TLauncher::~TLauncher()	+108	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TMapObjBase::~TMapObjBase()	+108	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	THitActor::~THitActor()	+108	0.00%	100.00%
mario/System/MarNameRefGen_Enemy	TSmallEnemyManager::~TSmallEnemyManager()	+100	0.00%	100.00%
mario/System/MarNameRefGen_MapObj	TFence::TFence(const char*)	+76	0.00%	100.00%
mario/System/MarNameRefGen_Map	.sdata2	+40	0.00%	100.00%
mario/System/MarNameRefGen_NPC	.sdata2	+8	0.00%	100.00%

📈 13 improvements in unmatched items

Unit	Item	Bytes	Before	After
mario/System/MarNameRefGen_MapObj	TMarNameRefGen::getNameRef_MapObj(const char*) const	+10330	0.00%	73.50%
mario/System/MarNameRefGen_MapObj	.rodata	+4492	0.00%	85.74%
mario/System/MarNameRefGen_Enemy	TMarNameRefGen::getNameRef_Enemy(const char*) const	+3154	0.00%	37.58%
mario/System/MarNameRefGen_Enemy	.rodata	+2711	0.00%	57.35%
mario/System/MarNameRefGen_NPC	TMarNameRefGen::getNameRef_NPC(const char*) const	+1912	0.00%	48.58%
mario/System/MarNameRefGen_Map	TMarNameRefGen::getNameRef_Map(const char*) const	+575	0.00%	69.89%
mario/System/MarNameRefGen_NPC	.rodata	+536	0.00%	50.39%
mario/System/MarNameRefGen_BossEnemy	.rodata	+472	0.00%	27.72%
mario/System/MarNameRefGen_BossEnemy	TMarNameRefGen::getNameRef_BossEnemy(const char*) const	+436	0.00%	16.32%
mario/System/MarNameRefGen_MapObj	.sdata2	+367	0.00%	91.87%
mario/System/MarNameRefGen_Map	.rodata	+197	0.00%	44.06%
mario/System/MarNameRefGen_Enemy	.sdata2	+95	0.00%	38.44%
mario/JSystem/JDrama/JDRNameRefGen	JDrama::TNameRefGen::getNameRef(const char*) const	0	67.57%	67.58%

[Mrkol]

Why'd you put the name into the ctor's default value in some cases but not in others? From what I see, it should be placed there in a bunch more cases present here, because the name is an unambiguous translation of the class name to Japanese