Make navbar cross-product docs links environment-aware#73
Merged
Conversation
The Documentation dropdown (and the mobile docs links) point at the other products' docs sites. They handled prod and localhost, but not the awsdev dev deployment — on dolthub.awsdev.ld-corp.com the dropdown sent you to the prod doltlab.com / doltgres.com docs. Add a devDocsLinks set for the *.awsdev.ld-corp.com hosts and pick the link set by hostname at runtime (localhost/127.0.0.1 -> local dev servers; *.awsdev.ld-corp.com -> dev; otherwise prod). Runtime detection is required because the same static build is deployed to all three environments, so the host is the only signal available; SSR/first paint still defaults to prod. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Documentation dropdown in the navbar (and the mobile docs links) jump between the Dolt / DoltLab / Doltgres docs sites. They handled prod and localhost, but not the awsdev dev deployment — so on
dolthub.awsdev.ld-corp.comthe dropdown sent you to the proddoltlab.com/doltgres.comdocs instead of the dev ones.Change
Added a
devDocsLinksset for the*.awsdev.ld-corp.comhosts and replaced the localhost-only check with a singledocsLinksForHost(hostname):localhost/127.0.0.1http://localhost:4321|4322|4323/docs*.awsdev.ld-corp.comhttps://{dolthub,doltlab,doltgres}.awsdev.ld-corp.com/docshttps://{dolthub.com,doltlab.com,doltgres.com}/docsDetection is at runtime (in the existing
useEffect) because all three sites ship one static build that's deployed to prod, awsdev, and the local dev servers alike — the serving host is the only signal. SSR / first paint still defaults to prod, same as before.Verification
astro buildon dolt is clean; confirmed the bundled navbar JS contains all three*.awsdev.ld-corp.comhosts and theendsWith(".awsdev.ld-corp.com")check.Out of scope
The Footer also has a single "Documentation" link hardcoded to
dolthub.com/docs, but the rest of the footer's links go towww.dolthub.com(the marketing site, no per-env split), so I left the footer alone to match the "documentation nav" ask. Easy to extend the same helper there if you want it.🤖 Generated with Claude Code