go/store/nbs: Delete the in-flight table file in (*fileTablePersister).writeAndProtect when we experience an error on the write.

[reltuk]

Leaving it behind needlessly wastes disk space. It will never be usable and is in an indeterminate state.

This is currently relevant even when FatalBehaviorFatal, because Conjoin's write is currently allowed to fail before we take the hard dependency on it. There are still some I/O errors which leave the file behind, including a failure at ftp.Open().

[coffeegoddd]

@reltuk DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.55	0.55	0.0
groupby_scan	9.91	9.91	0.0
index_join	1.86	1.86	0.0
index_join_scan	1.34	1.34	0.0
index_scan	20.74	20.74	0.0
oltp_point_select	0.26	0.26	0.0
oltp_read_only	5.09	5.09	0.0
select_random_points	0.51	0.51	0.0
select_random_ranges	0.56	0.56	0.0
table_scan	20.37	20.37	0.0
types_table_scan	45.79	45.79	0.0

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.21	6.21	0.0
oltp_insert	3.02	3.02	0.0
oltp_read_write	10.84	10.84	0.0
oltp_update_index	3.13	3.13	0.0
oltp_update_non_index	2.97	2.97	0.0
oltp_write_only	5.67	5.67	0.0
types_delete_insert	6.55	6.55	0.0

[coffeegoddd]

@reltuk DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	45.79	45.79	0.0

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	f200138	52.65	dolt	5234466	52.38	-0.51

[coffeegoddd]

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
5234466	ok	5937471

version	total_tests
5234466	5937471

correctness_percentage
100.0