Skip to content

Conversation

@abmyii
Copy link
Contributor

@abmyii abmyii commented Sep 8, 2021

Before:

b'\n\nA bad row was encountered while moving data.\nBad Row: \n"03AGDBQ24TPRIFU0LRPRHLHU8KBOK5SQSMCT8BMVFJNANULFUG4RDHNZPOV4PJNMN0DOD1PM2V5AQQTFP1HZXZG5J5BJTP7BN0A8WLBZYMBJIRU7BWTYCNXTCQUD1UYWITEJIZR5EWWP1NM4OR40P6FTQL4NHKIA870UAFXSPRF0AIK_45YNRU98ZQOZQNJFKNF89FW9" is not valid for "street_physical"\nThese can be ignored using the \'--continue\'\n'

After:

A bad row was encountered while moving data.
Bad Row: 
"03AGDBQ24TPRIFU0LRPRHLHU8KBOK5SQSMCT8BMVFJNANULFUG4RDHNZPOV4PJNMN0DOD1PM2V5AQQTFP1HZXZG5J5BJTP7BN0A8WLBZYMBJIRU7BWTYCNXTCQUD1UYWITEJIZR5EWWP1NM4OR40P6FTQL4NHKIA870UAFXSPRF0AIK_45YNRU98ZQOZQNJFKNF89FW9" is not valid for "street_physical" (schema "VarString(utf8mb4_0900_ai_ci, 180, SQL: VarChar)")
These can be ignored using the '--continue'

@abmyii abmyii force-pushed the decoded-error-messages branch 2 times, most recently from dcda6d4 to 1b2bcc4 Compare September 8, 2021 21:42
@max-hoffman
Copy link
Contributor

@abmyii Are you familiar with poetry? make lint, make fmt, and make test will run the same steps as our CI if you poetry install first.

@abmyii abmyii force-pushed the decoded-error-messages branch from 1b2bcc4 to 1a26e4c Compare September 8, 2021 22:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #27 (1a26e4c) into main (dd401d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files           5        5           
  Lines         972      972           
=======================================
  Hits          642      642           
  Misses        330      330           
Impacted Files Coverage Δ
doltcli/dolt.py 58.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd401d3...1a26e4c. Read the comment docs.

@max-hoffman max-hoffman self-requested a review September 8, 2021 22:22
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@max-hoffman max-hoffman merged commit a0c7604 into dolthub:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants