Skip to content

Issue #2197 Part 2#2254

Merged
Hydrocharged merged 1 commit intomainfrom
daylon/issue-2197-part-2
Feb 5, 2026
Merged

Issue #2197 Part 2#2254
Hydrocharged merged 1 commit intomainfrom
daylon/issue-2197-part-2

Conversation

@Hydrocharged
Copy link
Collaborator

This fixes the other issues brought up in:

This also adds support for column access, which is used by the UPDATE statement when a new column is added.

@Hydrocharged Hydrocharged requested a review from fulghum January 31, 2026 00:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Main PR
covering_index_scan_postgres 603.14/s 585.49/s -3.0%
index_join_postgres 123.95/s 121.52/s -2.0%
index_join_scan_postgres 184.92/s 183.68/s -0.7%
index_scan_postgres 11.45/s 11.23/s -2.0%
oltp_point_select 2367.96/s 2325.13/s -1.9%
oltp_read_only 1724.44/s 1704.68/s -1.2%
select_random_points 109.62/s 110.24/s +0.5%
select_random_ranges 448.46/s 439.24/s -2.1%
table_scan_postgres 11.32/s 11.30/s -0.2%
types_table_scan_postgres 5.21/s 5.19/s -0.4%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2026

Main PR
Total 42090 42090
Successful 17557 17557
Failures 24533 24533
Partial Successes1 5583 5583
Main PR
Successful 41.7130% 41.7130%
Failures 58.2870% 58.2870%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@Hydrocharged
Copy link
Collaborator Author

Regressions are from the GMS bump, as they're also on all other GMS bumps
#2257

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small things I noticed.

@Hydrocharged Hydrocharged force-pushed the daylon/issue-2197-part-2 branch from aed114f to 942b11c Compare February 5, 2026 10:52
@Hydrocharged Hydrocharged force-pushed the daylon/issue-2197-part-2 branch from 942b11c to 284ca20 Compare February 5, 2026 11:11
@Hydrocharged Hydrocharged disabled auto-merge February 5, 2026 11:56
@Hydrocharged Hydrocharged merged commit 47ac3a6 into main Feb 5, 2026
17 checks passed
@Hydrocharged Hydrocharged deleted the daylon/issue-2197-part-2 branch February 5, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants