Skip to content

Add comprehensive transaction tests for driver#41

Merged
coffeegoddd merged 1 commit into
dolthub:mainfrom
coffeegoddd:polecat/furiosa-tx-tests
Jan 15, 2026
Merged

Add comprehensive transaction tests for driver#41
coffeegoddd merged 1 commit into
dolthub:mainfrom
coffeegoddd:polecat/furiosa-tx-tests

Conversation

@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd coffeegoddd commented Jan 15, 2026

Summary

  • Added 4 new comprehensive tests covering transaction functionality
  • Improved overall code coverage from 83.2% to 86.1% (+2.9 percentage points)
  • Transaction-related functions (BeginTx, Commit, Rollback) now have full coverage, up from 0%

Tests Added

  1. TestTransactionCommit - Verifies transactions can be committed and changes persist
  2. TestTransactionRollback - Verifies rollbacks discard changes
  3. TestTransactionMultipleOperations - Tests atomic commit/rollback of multiple operations
  4. TestBeginTxUnsupportedIsolationLevel - Tests error handling for unsupported isolation levels

Test Results

All 23 tests passing (19 original + 4 new)

PASS
ok  	github.com/dolthub/driver	1.126s
coverage: 86.1% of statements

🤖 Generated with Claude Code

Added 4 new tests covering transaction functionality:
- TestTransactionCommit: Verifies transaction commits persist changes
- TestTransactionRollback: Verifies rollbacks discard changes
- TestTransactionMultipleOperations: Tests atomic commit/rollback of multiple operations
- TestBeginTxUnsupportedIsolationLevel: Tests error handling for unsupported isolation levels

Improves overall code coverage from 83.2% to 86.1%. Transaction-related functions (BeginTx, Commit, Rollback) now have full coverage, up from 0%.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coffeegoddd coffeegoddd force-pushed the polecat/furiosa-tx-tests branch from a4e7e25 to 1c5f8f4 Compare January 15, 2026 20:18
@coffeegoddd coffeegoddd requested review from reltuk and zachmu and removed request for zachmu January 15, 2026 20:20
Copy link
Copy Markdown
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd coffeegoddd merged commit 8ca7dc7 into dolthub:main Jan 15, 2026
3 checks passed
@coffeegoddd coffeegoddd deleted the polecat/furiosa-tx-tests branch January 15, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants