send metrics events on engine open#69
Merged
Merged
Conversation
coffeegoddd
reviewed
Feb 5, 2026
Contributor
There was a problem hiding this comment.
I'm not sure this is right... so every time the connector is opened, we launch a long-running go routine that ticks and emits a metrics event every 24 hours? When do these things die? And what if I'm opening thousands of connectors, like in the case of Beads/ GasTown?
If we want this type of behavior we should probably do something like write a file somewhere, then if that thing exists we dont send any events, and if it doesnt exist, we create it and send an event. and then, the next processes that come online can see if its been 24 hours since the file was created, and then in that case emit an event and recreate the file (reset the clock)... or something a bit fancier like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.