fix(quic): bounds-check varint lengths; isolate parser panics#232
Merged
fix(quic): bounds-check varint lengths; isolate parser panics#232
Conversation
Malformed QUIC Initial token_length, NEW_TOKEN, STREAM, NEW_CONNECTION_ID and CONNECTION_CLOSE fields could advance offset past payload.len(), panicking the pcap_rx thread on the next slice access. Guard each varint length addition and use checked_add for total_packet_size. Wrap parser.parse_packet in catch_unwind so a single crafted packet can no longer take down a capture thread and blind the monitor.
Fix unnecessary_sort_by, collapsible_match, and manual_checked_ops warnings surfaced by newer clippy on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed QUIC Initial token_length, NEW_TOKEN, STREAM, NEW_CONNECTION_ID and CONNECTION_CLOSE fields could advance offset past payload.len(), panicking the pcap_rx thread on the next slice access. Guard each varint length addition and use checked_add for total_packet_size.
Wrap parser.parse_packet in catch_unwind so a single crafted packet can no longer take down a capture thread and blind the monitor.