Construct autoenum's logger locally instead of importing from sphinx.…#125
Open
carterbox wants to merge 3 commits into
Open
Construct autoenum's logger locally instead of importing from sphinx.…#125carterbox wants to merge 3 commits into
carterbox wants to merge 3 commits into
Conversation
…ext.autodoc Sphinx 9 dropped the re-exported `logger` symbol from `sphinx.ext.autodoc` when the module was rewritten (sphinx-doc/sphinx#13751, #14089). Switch to `sphinx.util.logging.getLogger(__name__)`, which has been available since Sphinx 1.6 and produces an equivalent logger. This is the first error reported in domdfcoding#118. Note that full Sphinx 9 support is still blocked on sphinx-toolbox/sphinx-toolbox#201, which is the same bug in a runtime dependency. Once that lands, the sphinx<9 cap added in 121ac05 can be lifted. Refs: domdfcoding#118 Refs: sphinx-toolbox/sphinx-toolbox#201 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
for more information, see https://pre-commit.ci
|
coverage: 87.5% (+0.05%) from 87.452% — carterbox:fix-sphinx-9-autoenum into domdfcoding:master |
repo-helper
Bot
added
failure: Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ext.autodoc
Sphinx 9 dropped the re-exported
loggersymbol fromsphinx.ext.autodocwhen the module was rewritten (sphinx-doc/sphinx#13751, #14089). Switch tosphinx.util.logging.getLogger(__name__), which has been available since Sphinx 1.6 and produces an equivalent logger.This is the first error reported in #118. Note that full Sphinx 9 support is still blocked on sphinx-toolbox/sphinx-toolbox#201, which is the same bug in a runtime dependency. Once that lands, the sphinx<9 cap added in 121ac05 can be lifted.
Refs: #118
Refs: sphinx-toolbox/sphinx-toolbox#201