Refactor duplicated code across client and deduplication modules#2
Draft
Refactor duplicated code across client and deduplication modules#2
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: domfahey <789732+domfahey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code across the project
Refactor duplicated code across client and deduplication modules
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylint detected significant code duplication: 50+ line
_handle_error()methods duplicated across sync/async clients, identical_should_retry()logic, and 15+ lines of duplicate-finding code repeated in two scripts.Changes
Created
client_utils.pymodulehandle_error(response, endpoint)- converts HTTP errors to typed exceptionsshould_retry(status_code)- determines retriable status codesDexClientandAsyncDexClientAdded
find_all_duplicates()to deduplication module(matches, clusters)tuple for consistent access patternflag_duplicates.pyandresolve_duplicates.pyExample usage:
Impact
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.