Add CI workflow for PRs to main#58
Conversation
- Create `.github/workflows/ci.yaml` to run basic CI checks on new PRs to main. - Run `go mod tidy` and `go mod vendor` to update dependencies and vendor directory. - Format codebase using `gofumpt`. - Ensure repository state passes the new CI checks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
||
| - name: Ensure no modified or uncommitted files | ||
| run: | | ||
| git add . |
There was a problem hiding this comment.
The check should to ensure that the gofumpt andgo mod tidy` does not change any code
| git add . | |
| run: | | |
| if [ -n "$(git status --porcelain)" ]; then | |
| echo "Modified or uncommitted files found" | |
| git status --porcelain | |
| exit 1 | |
| fi |
There was a problem hiding this comment.
I've updated the workflow to use the suggested script for checking modified or uncommitted files.
| run: go mod tidy | ||
|
|
||
| - name: Run go mod vendor | ||
| run: go mod vendor |
There was a problem hiding this comment.
I changed my mind, please do not vendor the code.
There was a problem hiding this comment.
I've removed the vendoring step from the workflow and deleted the vendor/ directory from the repository.
- Create `.github/workflows/ci.yaml` for PR checks on main. - Remove vendor directory and related workflow step per PR feedback. - Update CI workflow to use `git status --porcelain` for uncommitted files check. - Ensure codebase is formatted and `go.sum` is updated.
1 participant
This PR adds a new GitHub Action workflow (
ci.yaml) that performs the following checks on pull requests targeting themainbranch:go mod tidygo mod vendorgofumptagainst the codeAdditionally, this PR updates the repository to satisfy these new CI requirements by:
vendor/directory.main.gousinggofumpt.PR created automatically by Jules for task 11583008319878649889 started by @dominikholler