linting, type safety, and CI pipeline#265
Merged
domino-blake merged 14 commits intomasterfrom Apr 29, 2026
Merged
Conversation
- Add .github/workflows/ci.yml with lint, typecheck, and test jobs
gating every PR and push to master
- Rewrite tox.ini to run full suite across Python 3.10/3.11/3.12
- Add coverage config to pytest.ini
- Update CHANGELOG
Contributor
ddl-bira-ignacio
left a comment
There was a problem hiding this comment.
Nice tidying up. Given the new quality enforcement steps here, we might want to add to the docs how devs can detect those failures locally and, for things that can be auto fixed with linting tools, how to run them.
ddl-bira-ignacio
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds automated quality gates and cleans up all pre-existing violations — no user-facing API changes.
CI / tooling
.github/workflows/ci.ymlwith three gating jobs:lint(black, isort, flake8,snake_case check),
typecheck(mypy), andtest(pytest matrix across Python 3.10/3.11/3.12)scripts/check_snake_case.py— an AST-based checker that prevents new camelCasepublic parameter names from being introduced
tox.inito cover all supported Python versionspyproject.tomlwith isort/black configType safety
domino/domino.py,domino/datasets.py,domino/_custom_metrics.py,domino/airflow/_operator.py,domino/agents/)Formatting
Testing
188 unit tests pass, 55 skipped (require live Domino deployment)
All pre-commit checks pass: black, isort, flake8, check_snake_case, mypy
Unit tests passing
No user-facing API changes
CI jobs validated locally