Fix handling module beginning with v and pragma with version.#10
Merged
charsbar merged 1 commit intodomm:masterfrom Aug 21, 2013
Merged
Fix handling module beginning with v and pragma with version.#10charsbar merged 1 commit intodomm:masterfrom
charsbar merged 1 commit intodomm:masterfrom
Conversation
charsbar
added a commit
that referenced
this pull request
Aug 21, 2013
Fix handling module beginning with v and pragma with version.
Collaborator
|
Thanks and sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following 2 issues are fixed by this pull request. Both are related with using
versionpragma.Please note that
t/20_parse_self.tis also adjusted becauseversionis ignored in the test.Details are as follows:
use version, just a letter'v'is matched to the rule<version>and the rest,'ersion'is left. The rule<use_stuff>is matched because the rule<version>is matched but the regex/[;}]/in the rule<token_use>is not matched to'ersion'. Thus, the rule<token_use>fails to match completely (don't backtrack).<version>not to match to words like'version'.use version 0.77can not be detected. Trying to match to the rule<pragma>, the rule<import_list>is matched to just a letter'0'then<token_use>fails the way similar to above.<pragma>to fall back to the rule<module>. I think this is fair because a pragma is just a module.