Skip to content

Fix the case for eval["']expr["'] and add regression tests.#3

Merged
domm merged 1 commit intodomm:masterfrom
yak1ex:eval_no_spaces_expr
Apr 16, 2013
Merged

Fix the case for eval["']expr["'] and add regression tests.#3
domm merged 1 commit intodomm:masterfrom
yak1ex:eval_no_spaces_expr

Conversation

@yak1ex
Copy link
Contributor

@yak1ex yak1ex commented Jan 28, 2013

eval EXPR could be no spaces between eval and EXPR for the case of eval'string'. However, the following regexp is used:

s/eval\s+(['"])(.*?)\1/$2;/

It should be

s/eval\s*(['"])(.*?)\1/$2;/

Corresponding tests are added.

NOTE: I am working on another pull request. If this pull request is accepted, I will make another one soon.

@domm domm merged commit e06096c into domm:master Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants