Skip to content

fix: upgrade phpunit to ^12.5, isolate mddoc via composer-bin-plugin#57

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/add-dev-dependency-mddoc
Draft

fix: upgrade phpunit to ^12.5, isolate mddoc via composer-bin-plugin#57
Copilot wants to merge 2 commits into
masterfrom
copilot/add-dev-dependency-mddoc

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 19, 2026

phpunit/phpunit ≤12.5.21 has an argument injection vulnerability via newlines in PHP INI values forwarded to child processes. The 9.x branch has no patch; the fix is 12.5.22+.

Dependency isolation

Upgrading to phpunit 12 pulls in nikic/php-parser ^5.7, which conflicts with donatj/mddoc's transitive requirement of phpdocumentor/reflection ~5.x (nikic/php-parser ^4.x). Resolved by moving mddoc into an isolated bin namespace:

  • Added bamarni/composer-bin-plugin ^1.8 to require-dev
  • Moved donatj/mddoc ^0.10 to vendor-bin/mddoc/composer.json
  • vendor/bin/mddoc symlink preserved via extra.bamarni-bin.bin-links: true
  • vendor-bin/*/vendor/ added to .gitignore

phpunit 12 migration

  • phpunit/phpunit ~9^12.5 (installs 12.5.23)
  • phpunit.xml.dist: <filter>/<whitelist><source>/<include> (required by phpunit 10+)
  • @dataProvider docblock annotations → #[DataProvider] PHP attributes (annotation removed in phpunit 10)
  • CI matrix pruned to PHP 8.3, 8.4, 8.5 — phpunit 12 requires PHP ≥8.3

Copilot AI and others added 2 commits April 19, 2026 15:33
…ingway-style description

Agent-Logs-Url: https://github.com/donatj/printf-parser/sessions/13c0d3a2-8c38-427a-9235-3acf0926332a

Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
…te mddoc via composer-bin-plugin

Agent-Logs-Url: https://github.com/donatj/printf-parser/sessions/13c0d3a2-8c38-427a-9235-3acf0926332a

Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants