Merged
Conversation
…tedChoresData in bulk actions
…ate related components
…or archive/unarchive actions and add delete option
…isibility in dark mode
…d of default only
…ing logic to match choreHistory card
…arsing logic for unspecified times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the chores management features, focusing on due date handling, UI consistency, bulk actions, and history/status tracking. The main changes include refining how end-of-day times are handled for chores, enhancing the UI for archiving and deleting chores, updating bulk action logic, and adding new status types for chore histories.
Due date handling and consistency:
23:59:59as the end-of-day time for chores, ensuring that date-only chores are consistently treated as due at the end of the day across the application. This affects how due dates are set, displayed, and interpreted in both the edit and display components. [1] [2] [3] [4] [5]Chore status and history enhancements:
ChoreHistoryStatusvalues:MISSEDandRESCHEDULED, and updated UI components to display these new statuses with appropriate icons and colors. Also improved the logic for counting and displaying completed and skipped chores in history views. [1] [2] [3] [4] [5] [6] [7] [8]Chore edit and view UI improvements:
ChoreEditto use a dropdown menu for better UX, and updated logic to handle archiving/unarchiving chores more intuitively.ChoreViewto depend onchore.isActive, ensuring actions are only available for active chores. [1] [2] [3] [4] [5] [6]Bulk actions and filtering logic:
Other improvements and bug fixes:
dueDateis not set.updatedAtifperformedAtis missing, ensuring all activities are grouped correctly.These changes collectively enhance the reliability, clarity, and user experience of the chores management features.