Skip to content

Reading kifuku from new pitchCategories field#35

Merged
bewizible merged 4 commits intodonkuri:mainfrom
itokatsu:use_yomitan_pitch_categories
Jan 9, 2025
Merged

Reading kifuku from new pitchCategories field#35
bewizible merged 4 commits intodonkuri:mainfrom
itokatsu:use_yomitan_pitch_categories

Conversation

@itokatsu
Copy link
Contributor

Tries to handles #29
Not really happy with the code looks. We could probably rework this further to use this for all the categories.

I'm reading from PitchPosition with I've set as {pitch-accent-positions}{pitch-accent-categories} for this purpose.
We could change the pitchCategories function to use a split instead of that regex if we make a new field for categories.

Haven't tested it a lot either, but it handles おっぱい correctly.

@itokatsu itokatsu changed the title Attempt to handle kifuku with pitch-categories Reading kifuku from new pitchCategories field Dec 29, 2024
@bewizible bewizible merged commit a18c762 into donkuri:main Jan 9, 2025
@Skretkowicz
Copy link

Is there anything we can do to update the cards created before 1.4.0?

@bewizible
Copy link
Collaborator

Sadly, no, unless @itokatsu knows otherwise

@itokatsu
Copy link
Contributor Author

itokatsu commented Jan 12, 2025

Oh you mean backfilling ? Sadly no way to automate this.
But you could manually write "atamadaka" in PitchCategories when you see a card wrongly set to kifuku. (or nakadaka, but it doesn't matter. The thing that matters is that it has a valid pitch type and no kifuku)

@itokatsu itokatsu deleted the use_yomitan_pitch_categories branch January 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants