Skip to content

⏫Update UIKit 3.1.6 to 3.5.4#21

Merged
dons20 merged 4 commits into
dons20:masterfrom
yussufbiyik:master
Jun 14, 2020
Merged

⏫Update UIKit 3.1.6 to 3.5.4#21
dons20 merged 4 commits into
dons20:masterfrom
yussufbiyik:master

Conversation

@yussufbiyik
Copy link
Copy Markdown
Contributor

@yussufbiyik yussufbiyik commented Jun 14, 2020

UIKit 3.1.4 was not supporting font-weight classes and many other new features so i changed links to uikit 3.5.4 i was not able to test it in vscode but made my test manually and it worked. Instead of cloudflare links you can use the original snippet from uikit documents

<!-- UIkit CSS -->
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/uikit@3.5.4/dist/css/uikit.min.css" />

<!-- UIkit JS -->
<script src="https://cdn.jsdelivr.net/npm/uikit@3.5.4/dist/js/uikit.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/uikit@3.5.4/dist/js/uikit-icons.min.js"></script>

@yussufbiyik
Copy link
Copy Markdown
Contributor Author

I just tested and it works!

I had to delete integrity attributes to make grid elements stable again(grid elements was not able to align horizontally).

@dons20
Copy link
Copy Markdown
Owner

dons20 commented Jun 14, 2020

Thanks for the PR, I'll quickly review and merge 👍🏾

@dons20
Copy link
Copy Markdown
Owner

dons20 commented Jun 14, 2020

Regarding changing the links from cdnjs to jsdelivr, I'm not sure there is much point to it. I think they function identically from my usage. Also, the reason the integrity attribute was affecting it was because it also needs to be updated on each release. I get the SRI fresh for each version on CDNJS but you can also get it from JSDelivr as well.

Since it's still using CDNJS, you can head over to the link, click the little dropdown beside the relevant section and copy the SRI and paste where applicable.
image

That should fix the integrity issue. Try testing that out.

Added integrity attribute again
@yussufbiyik
Copy link
Copy Markdown
Contributor Author

Thank you! I added integrity attribute again with sri i got from cdnjs and it works perfectly fine.

@dons20
Copy link
Copy Markdown
Owner

dons20 commented Jun 14, 2020

Awesome, merging and will publish a minor version today.

@dons20 dons20 merged commit 5b3136b into dons20:master Jun 14, 2020
@yussufbiyik
Copy link
Copy Markdown
Contributor Author

yussufbiyik commented Jun 14, 2020

Thank you for all the responses, I am really happy that i was able to help.

dons20 added a commit that referenced this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants