Add an icon for *.R files in treemacs extension

[atanasj]

Describe the feature

The R icon does not appear in the treemacs window. This has been implemented in both all-the-icons and treemacs. Having this would improve the UI when working with R and ess, and make files associated with R easier to identify visually in the the treemacs sidebar.

Can this be brought into doom somehow? Or is it something I need to do in my own config?

System information

Details

Place the output of `M-x doom/info` or `~/.emacs.d/bin/doom info` here.
SYSTEM  type       darwin
        config     x86_64-apple-darwin19.6.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu Oct 29 22:56:45 PDT 2020; root:xnu-6153.141.2.2~1/RELEASE_X86_64 x86_64
        path       (~/.pyenv/shims ~/.pyenv/bin ~/.rbenv/shims ~/.rbenv/bin /Applications/Mplus /usr/local/bin /usr/bin /bin /usr/sbin /sbin /usr/local/MacGPG2/bin /usr/local/share/dotnet /opt/X11/bin ~/.dotnet/tools /Library/Apple/usr/bin /Library/Frameworks/Mono.framework/Versions/Current/Commands ~/.cargo/bin ~/doom-emacs/bin ~/.nvm/versions/node/v12.4.0/bin /private/var/folders/77/7ht3td2j1vb00csyp1l4wlv40000gn/T/build-openssl@1.1/opt/openssl@1.1/bin /opt/local/bin /opt/local/sbin /usr/local/opt/sqlite/bin ~/perl5/perlbrew/bin ~/perl5/perlbrew/perls/perl-5.26.1/bin /usr/local/ActivePerl-5.24/bin ~/bin /usr/local/opt/sphinx-doc/bin /usr/local/opt/libxml2/bin /usr/local/opt/curl/bin /usr/local/opt/coreutils/libexec/gnubin ~/.pandoc/filters /usr/local/opt/openjdk/bin /usr/local/lib /usr/local/sbin ~/.local/bin ~/go/bin /usr/local/opt/go/libexec/bin ~/.antigen/bundles/robbyrussell/oh-my-zsh/lib ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/tmuxinator ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/colored-man-pages ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/common-aliases ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/extract ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/fancy-ctrl-z ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/git ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/gitfast ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/sudo ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/z ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/node ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/osx ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/iterm2 ~/.antigen/bundles/hlissner/zsh-autopair ~/.antigen/bundles/zsh-users/zsh-completions ~/.antigen/bundles/zsh-users/zsh-autosuggestions ~/.antigen/bundles/zsh-users/zsh-history-substring-search ~/.antigen/bundles/zdharma/fast-syntax-highlighting ~/.antigen/bundles/robbyrussell/oh-my-zsh/plugins/fzf ~/.antigen/bundles/andrewferrier/fzf-z ~/.antigen/bundles/agkozak/zsh-z ~/.antigen/bundles/mafredri/zsh-async ~/.antigen/bundles/sindresorhus/pure ~/.fzf/bin /usr/local/Cellar/emacs-plus@28/28.0.50/libexec/emacs/28.0.50/x86_64-apple-darwin19.6.0)
EMACS   dir        ~/.emacs.d/
        version    28.0.50
        build      Dec 29, 2020
        buildopts  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2 --with-gnutls --with-nativecomp --without-dbus --with-imagemagick --with-modules --with-rsvg --with-xwidgets --with-ns --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/10 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include'
        features   JPEG TIFF GIF PNG RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES NATIVE_COMP THREADS XWIDGETS JSON PDUMPER LCMS2
        traits     (batch server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        build      HEAD -> develop fd7073240 2021-01-23 22:37:28 -0500
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo hydra indent-guides modeline nav-flash ophints (popup +all +defaults) (ligatures +pretty-code) treemacs vc-gutter vi-tilde-fringe window-select workspaces zen :editor (evil +everywhere) file-templates fold lispy multiple-cursors rotate-text snippets :emacs dired electric ibuffer vc :term vterm :checkers (syntax +flycheck) (spell +flyspell) :tools editorconfig (eval +overlay) gist (lookup +docsets) lsp magit pdf tmux :lang clojure data emacs-lisp ess latex lua markdown (org +dragndrop +pandoc +present) python sh (&nopath email) :config (default +bindings +smartparens))
        packages   ((flyspell-correct :recipe (:host github :repo d12frosted/flyspell-correct)) (flyspell-correct-ivy :recipe (:host github :repo d12frosted/flyspell-correct :files (flyspell-correct-ivy.el))) (flyspell-lazy) (writegood-mode) (xterm-color) (yaml-mode) (polymode) (poly-markdown) (poly-R) (ess-view) (company-box) (pandoc-mode) (ebib) (auctex) (auctex-latexmk) (company-auctex) (all-the-icons-ivy-rich) (all-the-icons-ibuffer) (rainbow-mode) (openwith) (auto-complete) (vba-mode :recipe (:host github :repo ayanyan/vba-mode)) (vimrc-mode) (zoom) (lsp-lua-emmy :recipe (:host github :repo phenix3443/lsp-lua-emmy)) (all-the-icons-dired :recipe (:host github :repo jtbm37/all-the-icons-dired)) (evil-terminal-cursor-changer :recipe (:host github :repo 7696122/evil-terminal-cursor-changer)) (fennel-mode :recipe (:host gitlab :repo technomancy/fennel-mode)))
        unpin      (flyspell-correct flyspell-correct-ivy)
        elpa       (treemacs-all-the-icons treemacs s posframe pfuture lv hydra ht f dash cfrs avy all-the-icons ace-window)

[corderophi678]

Have you tried adding (setq doom-themes-treemacs-theme "Default") to your config? Because it looks like emacs-doom-themes sets the treemacs theme according to the doom-theme you've selected. This worked for me, at any rate.

[atanasj]

Thanks @corderophi678, that did work. However, it would be nice of doom-theme incorporated these icons and doomified them... I suppose that is a feature request...? @hlissner, would this be possible in emacs-doom-themes?

[ema2159]

It is an issue with all-the-icons. Doom-themes uses the all-the-icons-icon-alist variable to grab all the file extensions and their respective icons. This variable is defined in the file all-the-icons.el file in the respective repository. The issue in question is in line 254:

    ("\\.r[ds]?x?$"     all-the-icons-fileicon "R"                      :face all-the-icons-lblue)

That regex doesn't seem to be right, because it misses the extensions that it's supposed to catch, but I'm not sure how to fix it properly. I'll try to look into it, but if any of you is more comfortable with elisp regexes, please feel free to lend me hand.

[ema2159]

Also, if you want separate icons per file type in treemacs, you have to do:

(setq doom-themes-treemacs-theme "doom-colors")

[atanasj]

I wish I could help... But I look forward to any additions... Thanks.

[atanasj]

@ema2159, I changed the regex pattern to "\\.r[ds]?+?$" which seemed to work in the regexp-builder in emacs. However, when testing the updated all-the-icons.el, the icons were not picked up. Not sure if this is helpful or not, but I was guided by this page.

    ("\\.r[ds]?+?$"     all-the-icons-fileicon "R"                      :face all-the-icons-lblue)

Not to sure where to from here.

[ema2159]

Indeed. That's quite weird, your regex works (and also the original) when using the regexp builder, however, it doesn't seem to work only in treemacs (in centaur-tabs I use a similar approach for the tabs icons and it does work with .r files). Oddly enough, if you put a plain "\.r$" for selecting r icons, it does work.

[atanasj]

…works in treemacs? That is weird. I suppose that particular pattern is useful for other types of R documentation... Hmmm, where to from here?

[hlissner]

I've specifically added *.R support in 35b86f2 (and improved our icon support in general) for our doom-colors treemacs theme. Our reverse engineering all-the-icons-icon-alist struggles with more complex regexps (like the one for R files), so an explicit mapping was needed. Let me know if that doesn't resolve the issue and I'll reopen this. Thanks for bringing it to my attention!

[atanasj]

@hlissner, thanks for that. I can confirm it is working!

I wonder whether it would also be possible to assoicate the .Rmd format with .md, as it is done in vscode?

Or Rstudio:

Or for other R file extension types, such as documentation .Rd? Again, this is excellent work, so these others are just nice to haves. :-)