fix: updateColumn() / increment() / decrement() use buildWhereClause()#216
Merged
techmahedy merged 1 commit intodoppar:3.xfrom Mar 11, 2026
Merged
fix: updateColumn() / increment() / decrement() use buildWhereClause()#216techmahedy merged 1 commit intodoppar:3.xfrom
techmahedy merged 1 commit intodoppar:3.xfrom
Conversation
…) instead of legacy condition loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateColumn() was manually iterating conditions with a hardcoded $condition[1] $condition[2] ? pattern, causing broken SQL and mismatched bindings for any non-simple condition. whereIn, whereNull, whereBetween, and nested wheres all produced incorrect queries. Replaced with buildWhereClause() and manual sequential binding — amount and extra columns bound first, then where bindings, matching the SQL parameter order.