Fix redundant instantiations and uncached reflection in model internals#246
Merged
techmahedy merged 1 commit intodoppar:3.xfrom Apr 16, 2026
Merged
Fix redundant instantiations and uncached reflection in model internals#246techmahedy merged 1 commit intodoppar:3.xfrom
techmahedy merged 1 commit intodoppar:3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three performance issues found and fixed in
InteractsWithModelQueryProcessing:update()— reflection ran on every call —propertyHasAttribute()creates aReflectionClassinternally. It was called on everyupdate()with no caching, so a model that is updated 100 times in a request paid the reflection cost 100 times.saveMany()— 3 model instances created, only 1 needed —(new static())->propertyHasAttribute(new static(), ...)allocated two extra model instances when the already-created$modelvariable was sitting right there.getClassProperty()— called deprecatedsetAccessible()—ReflectionProperty::setAccessible()has been a no-op since PHP 8.1 and triggers a deprecation notice in PHP 8.3. The call was removed.