Fix: per-request singleton state leakage in worker mode#275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In worker mode, the PHP process stays alive across requests. The DI container stores resolved singletons in private static array
$instances, which is never cleared between requests. This means it may leak user-specific state from Request 1 into Request 2.This is invisible in development (spawns a fresh process per request) and only surfaces under real concurrent traffic in worker mode — making it a silent production security issue.
Does this break anything
No existing behaviour changes in PHP-FPM mode — processes reset between requests naturally, so the terminating callback runs but nulling already-null instances is a no-op