feat: add cross-database foreign key configuration#554
Merged
dosco merged 2 commits intodosco:masterfrom Mar 12, 2026
Merged
Conversation
Enable `related_to` config to reference tables in other databases using colon-separated syntax (e.g. `ats:employees.id`). This bridges the gap between GraphJin's existing cross-database join runtime and config-time FK declaration, allowing relationships like `job_crew.employee_id` in `ats_orders` to reference `employees.id` in `ats`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NormalizeDatabases, finalizeDatabaseSchema, and ensureDiscoveredTablesInConfig all mutate Config.Tables/Databases/Roles. When the same *Config is reused across multiple NewGraphJin calls, these mutations accumulate and can cause duplicate table entries or stale state. Deep-copy the mutable fields at init time so the caller's original Config is never modified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
related_toconfig for cross-database FK references (e.g.ats:employees.id)RelDatabaseJoinruntime pathDetails
Previously, configuring
related_to: "ats.employees.id"on a table inats_orderswould fail because GraphJin parsed it asschema.table.columnand looked it up in the local database only. The new syntaxats:employees.idunambiguously separates the database name from the schema/table/column path and resolves the target column against the correct database'sDBInfo.Backward compatible — values without
:parse identically to the existing behavior.Test plan
getFKparsing with all syntax variants (2-part, 3-part, cross-db 2-part, cross-db 3-part, invalid)addForeignKeysFKeyDatabaseset)IsCrossDatabase()verification🤖 Generated with Claude Code