Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Allow users to insert videos from external sources #23861

Closed
Tracked by #21988
fmontes opened this issue Jan 20, 2023 · 7 comments · Fixed by #23933, #24248 or #24409
Closed
Tracked by #21988

Block Editor: Allow users to insert videos from external sources #23861

fmontes opened this issue Jan 20, 2023 · 7 comments · Fixed by #23933, #24248 or #24409
Assignees
@rjvelazco @josemejias07
Labels
OKR : Core Features Owned by Will OKR : Marketing Owned by Todd OKR : Sales Owned by Dean OKR : User Experience Owned by Jason Priority : 2 High QA : Approved QA : Passed Internal Release : 23.03 Team : Lunik

Comments

@fmontes
Copy link
Member

fmontes commented Jan 20, 2023

User Story

As a user, I want to be able to search and insert videos from external sources (URL) into the block editor.

Acceptance Criteria

  1. User will enter the URL into the field
  2. User can insert the image by clicking the button or tabbing into focus the button and hit enter the keyboard.
  3. The image gets inserted in the editor

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
@josemejias07
Copy link

Failed QA - Tested on 23.03_22c57977_SNAPSHOT // Docker // macOS 13.0 // FF v110.0

' No video supported format and MIME type found ' message showing.

Screen.Recording.2023-03-01.at.1.47.24.PM.mov

@rjvelazco
Copy link
Contributor

rjvelazco commented Mar 7, 2023 •
edited

@josemejias07

Like YouTube, Vimeo embed links are not just videos, they are typically webpages that contain logic. As you can see, the link you are trying to add should not be used with a <video> but <iframe>.

Image

@rjvelazco rjvelazco linked a pull request Mar 7, 2023 that will close this issue
dotCMS/core#23436 Block Editor: Create video block node and insert from dotCMS content #23933
Merged
@fmontes fmontes linked a pull request Mar 7, 2023 that will close this issue
Bock Editor: Allow user to insert videos from local files #23863 #24248
Merged
@fmontes
Copy link
Member Author

fmontes commented Mar 14, 2023

Video files URL not web pages that have a video in it.

@fmontes
Copy link
Member Author

fmontes commented Mar 14, 2023

We're creating a YouTube video support.

@fmontes
Copy link
Member Author

fmontes commented Mar 14, 2023

Catch the error when is not a mime type video.

rjvelazco added a commit that referenced this issue Mar 17, 2023
@rjvelazco
dev: add video validation #23861
9cea68f
@rjvelazco rjvelazco linked a pull request Mar 17, 2023 that will close this issue
Block Editor: Allow users to insert videos from external sources#23861 #24409
Merged
fmontes added a commit that referenced this issue Mar 20, 2023
@rjvelazco @fmontes
Block Editor: Allow users to insert videos from external sources#23861 (
fb6e085 
#24409)

* dev: validate video url

* dev: add video validation #23861

* clean up

* fix merge conflicts

* update dotcms-block-editor.js

* dev: add support link to unknown errors

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* update dotcms-block-editor.js

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
@fmontes
Copy link
Member Author

fmontes commented Mar 20, 2023

No video URL error is catch now, youtube and other features will be in new issues.

@josemejias07
Copy link

Approved QA - Tested on 23.03_fb6e0850_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

fmontes added a commit that referenced this issue Mar 28, 2023
@jcastro-dotcms @victoralfaro-dotcms
@rjvelazco @alfredo-dotcms @fmontes @manuelrojas @zulqarnainvd @hassan-mustafa-baig @wezell @erickgonzalez @jdotcms
Merging 23 03 to master (#24470)
da2f8b1 
* Update release version for dotcms-ui and dotcms-webcomponents

* Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03

* Update branch in git submodule to release-23.03

* Excluding from triggering test at folder: dotCMS/src/main/webapp/html

* #23977 Block editor freeze scroll on tippy menus show (#24180)

* dev: freeze scroll on show forms #23977

* clean up

* refactor

* clean up v2

* feedback

* clean up

* #24172 Refresh Page portlet's data when site changed (#24175)

* #24031 fix block editor not saving (#24222)

* Fix #24032 Bring it to 22.03 (#24229)

* Fix #24032 Bring it to 22.03

* Build de lib

---------

Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>

* #24240 Fix data-access tests in 23.03 (#24244)

* #24240 fix test cases

* #24240 fix lint

* fire release docker image generation

* #24221 fix Snapshots should be displayed when the language is changed (#24234)

* Fix #23449 show dotAssets in folder listing

* Bock Editor: Allow user to insert videos from local files#23863 (#24248)

* dev: remove fileSize limit and fit the video in the block editor #23863

* clean up

* Fix 24032: Adding for Internal QA (#24255)

* #24032 Adding Fix for Internal QA

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Logging error

* dotCMS/core#issue-20432 adding const

* dotCMS/core#issue-20432 adding const

* #24032 validation schema

* Adding empty extensions

* Adding empty extensions

* Get all modules no actions required

* Adding optional validation for actions

* Adding optional validation for actions

* Adding id insted of name

* Adding Type for promise

* Adding dot-cms-block-editor

* Adding lock file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #22151 make the message better (#24041)

* #22151 make the message better

* #22151 hides token button if aws

* #24173 Create dialog for 'Create Page' button (#24215)

* #24173 Create dialog for 'Create Page' button

* #24173 Create dialog for 'Create Page' button - tests

* #24173 Create dialog for 'Create Page' button - feedback

* #24173 Create dialog for 'Create Page' button - more feedback

* #23901 fixes the git hash resolution (#23902)

* #23889 fixed content permission load issue (#24296)

* #24308 Can't search for contentlets in edit page palette (#24316)

* #24308 fixed contentlets search

* #24308 refactor test case

* #24308 refactor code

* #24243 fixed squash between hint icon  and label (#24298)

* dev: update block editor (#24323)

* [Issue-23863]: Fix #23863 Max Dimensions for Videos and Images (#24338)

* #23863 adding fix for max dimensions

* Adding editor

* Fix label

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* mockPrintWriter (#24352)

* #24263 prevent empty save block editor field (#24342)

* Fix #24230 Block editor markdown content with javascript code is breaking the app (#24359)

* #24230

* #24230  clean up

* #24230 moving logic to the JSP

* [Issue 24370] block editor crashing with allowed blocks (#24375)

* #24370  Fixing undefined this

* #24370  Fixing undefined this

* Fix #23863 block editor allow user to insert videos from local files fix size (#24374)

* dev: prevent close form while uploading asset #23863

* fix: large videos preview

* clean up

* update block editor

* feedback

* dev: update dotcms-block-editor.js file

* Block Editor: Allow users to insert videos from external sources#23861 (#24409)

* dev: validate video url

* dev: add video validation #23861

* clean up

* fix merge conflicts

* update dotcms-block-editor.js

* dev: add support link to unknown errors

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* update dotcms-block-editor.js

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* Fix #24361 block editor code block should not show suggestions or placeholder (#24403)

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* build file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #24422 fixes render

* Update LTS check

* Fix #23863 let user cancel upload (#24417)

* dev: let user cancel upload #23863

* update dotcms-block-editor.js

* clean up

* feedback

* update dotcms-block-editor.js

* dev: upload automatically after selecting the video

* Fix #24263: get the correct input element for block editor (#24429)

* Fix #23449 Filter does not work on the image selector for image fields 

* Moved code to a new branch

* Fix for the DB query

* Fixed failing ITs also addressed the PR feedback

* Added javadoc

* Fixed the failing test

* Fixed some ITs

* Fix postman tests

* Fixed postman tests

* Addressed PR feedback

* Making sonar happy

* Adding more code changes.

* Removed unnecessary file

* Fixed luceneQuery to fix failing ITs

* Adding `showOnMenu` term to lucene query.

* Updating reindex policy in Integration Test to wait for the ES reindex to be done when saving the test files.

* Adding temporary logging to the Integration Test

* Force indexation.

* Print more info.

* Removing `SYSTEM_HOST` from DB query.

* Fixing Integration Test.

---------

Co-authored-by: Jose Castro <jose.castro@dotcms.com>

* Fix #24299 now the get dependencies do not throw an exception when the story block value is not a json (#24439)

* Bock Editor: Allow user to insert videos from local files #23863 (#24451)

* dev: support video file and dotAsset #23863

* update dotcms-block-editor.js file

* dev: update label to Library and dotcms-block-editor.js file

* Block editor value [Object, object] fix (#24474)

* Updating branch references

* dev: rename video node (#24477)

* dev: restore data mock time (#24478)

* Fix conflict

* Fix lock

* Point to master

* Fix lock

* Fixing merging conflict.

---------

Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com>
Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

@josemejias07 josemejias07

Labels
OKR : Core Features Owned by Will OKR : Marketing Owned by Todd OKR : Sales Owned by Dean OKR : User Experience Owned by Jason Priority : 2 High QA : Approved QA : Passed Internal Release : 23.03 Team : Lunik
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
5 participants
@fmontes @erickgonzalez @rjvelazco @josemejias07 @damen-dotcms