[Issue 24370] block editor crashing with allowed blocks #24375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontes
approved these changes
Mar 14, 2023
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
fmontes
deleted the
issue-24370-block-editor-crashing-with-allowedblocks
branch
fmontes
added a commit
that referenced
this pull request
Mar 28, 2023
* Update release version for dotcms-ui and dotcms-webcomponents * Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03 * Update branch in git submodule to release-23.03 * Excluding from triggering test at folder: dotCMS/src/main/webapp/html * #23977 Block editor freeze scroll on tippy menus show (#24180) * dev: freeze scroll on show forms #23977 * clean up * refactor * clean up v2 * feedback * clean up * #24172 Refresh Page portlet's data when site changed (#24175) * #24031 fix block editor not saving (#24222) * Fix #24032 Bring it to 22.03 (#24229) * Fix #24032 Bring it to 22.03 * Build de lib --------- Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> * #24240 Fix data-access tests in 23.03 (#24244) * #24240 fix test cases * #24240 fix lint * fire release docker image generation * #24221 fix Snapshots should be displayed when the language is changed (#24234) * Fix #23449 show dotAssets in folder listing * Bock Editor: Allow user to insert videos from local files#23863 (#24248) * dev: remove fileSize limit and fit the video in the block editor #23863 * clean up * Fix 24032: Adding for Internal QA (#24255) * #24032 Adding Fix for Internal QA * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Adding PR Feedback * #24032 Logging error * dotCMS/core#issue-20432 adding const * dotCMS/core#issue-20432 adding const * #24032 validation schema * Adding empty extensions * Adding empty extensions * Get all modules no actions required * Adding optional validation for actions * Adding optional validation for actions * Adding id insted of name * Adding Type for promise * Adding dot-cms-block-editor * Adding lock file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #22151 make the message better (#24041) * #22151 make the message better * #22151 hides token button if aws * #24173 Create dialog for 'Create Page' button (#24215) * #24173 Create dialog for 'Create Page' button * #24173 Create dialog for 'Create Page' button - tests * #24173 Create dialog for 'Create Page' button - feedback * #24173 Create dialog for 'Create Page' button - more feedback * #23901 fixes the git hash resolution (#23902) * #23889 fixed content permission load issue (#24296) * #24308 Can't search for contentlets in edit page palette (#24316) * #24308 fixed contentlets search * #24308 refactor test case * #24308 refactor code * #24243 fixed squash between hint icon and label (#24298) * dev: update block editor (#24323) * [Issue-23863]: Fix #23863 Max Dimensions for Videos and Images (#24338) * #23863 adding fix for max dimensions * Adding editor * Fix label --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * mockPrintWriter (#24352) * #24263 prevent empty save block editor field (#24342) * Fix #24230 Block editor markdown content with javascript code is breaking the app (#24359) * #24230 * #24230 clean up * #24230 moving logic to the JSP * [Issue 24370] block editor crashing with allowed blocks (#24375) * #24370 Fixing undefined this * #24370 Fixing undefined this * Fix #23863 block editor allow user to insert videos from local files fix size (#24374) * dev: prevent close form while uploading asset #23863 * fix: large videos preview * clean up * update block editor * feedback * dev: update dotcms-block-editor.js file * Block Editor: Allow users to insert videos from external sources#23861 (#24409) * dev: validate video url * dev: add video validation #23861 * clean up * fix merge conflicts * update dotcms-block-editor.js * dev: add support link to unknown errors * Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts * Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts * update dotcms-block-editor.js --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * Fix #24361 block editor code block should not show suggestions or placeholder (#24403) * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * #24361 Blocking suggestions and placeholder * build file --------- Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * #24422 fixes render * Update LTS check * Fix #23863 let user cancel upload (#24417) * dev: let user cancel upload #23863 * update dotcms-block-editor.js * clean up * feedback * update dotcms-block-editor.js * dev: upload automatically after selecting the video * Fix #24263: get the correct input element for block editor (#24429) * Fix #23449 Filter does not work on the image selector for image fields * Moved code to a new branch * Fix for the DB query * Fixed failing ITs also addressed the PR feedback * Added javadoc * Fixed the failing test * Fixed some ITs * Fix postman tests * Fixed postman tests * Addressed PR feedback * Making sonar happy * Adding more code changes. * Removed unnecessary file * Fixed luceneQuery to fix failing ITs * Adding `showOnMenu` term to lucene query. * Updating reindex policy in Integration Test to wait for the ES reindex to be done when saving the test files. * Adding temporary logging to the Integration Test * Force indexation. * Print more info. * Removing `SYSTEM_HOST` from DB query. * Fixing Integration Test. --------- Co-authored-by: Jose Castro <jose.castro@dotcms.com> * Fix #24299 now the get dependencies do not throw an exception when the story block value is not a json (#24439) * Bock Editor: Allow user to insert videos from local files #23863 (#24451) * dev: support video file and dotAsset #23863 * update dotcms-block-editor.js file * dev: update label to Library and dotcms-block-editor.js file * Block editor value [Object, object] fix (#24474) * Updating branch references * dev: rename video node (#24477) * dev: restore data mock time (#24478) * Fix conflict * Fix lock * Point to master * Fix lock * Fixing merging conflict. --------- Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com> Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
thisbut it was moved to a helper function.Checklist
Additional Info
** any additional useful context or info **
Screenshots