Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering converted wysiwyg field fails #24422

Closed
wezell opened this issue Mar 20, 2023 · 1 comment
Closed

Rendering converted wysiwyg field fails #24422

wezell opened this issue Mar 20, 2023 · 1 comment
Assignees
@fmontes
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.01.3 Included in LTS patch release 23.01.3 Release : 23.03 Team : Lunik Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Mar 20, 2023

Parent Issue

No response

Problem Statement

When we convert a WYSIWYG field to a blockeditor, we do not touch the content in the field. The issue arises when the converted wysiwyg field has velocity or code in it - we are not properly escaping the field in our content loader. This causes a container to show an empty contentlet in it and basically fail to operate in edit mode.

Steps to Reproduce

  1. In the starter, create an empty page
  2. In EDIT MODE, drag a "rich text" object onto it and in the rich text area (code view) paste:
#set($testing = "This seems to be working")
<h1>$testing</h1>
In fact, <a href="https://www.testing.com/en/documents/3901469">testing link</a>
"
final testing

  1. save this and it should show up on your page:
    Screen Shot 2023-03-20 at 7 16 41 PM

  2. Edit the Rich Text content type, change the WYSIWYG to a StoryBlock field

  3. Flush all caches

  4. return to your page in EDIT MODE, the container is empty and you will not be able to add more content on container - nor will you be able to remove the bad content that is there.

Acceptance Criteria

Changing a field to storyblock should not blow up the rendering of a page.

dotCMS Version

23.01

Proposed Objective

Reliability

Proposed Priority

Priority 1 - Show Stopper

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
wezell added a commit that referenced this issue Mar 20, 2023
@wezell
#24422 fixes render
b88e454
wezell added a commit that referenced this issue Mar 21, 2023
@wezell
#24422 fixes render
c4713d2
@fmontes fmontes self-assigned this Mar 21, 2023
@bryanboza
Copy link
Member

Fixed, tested on release-22.03 // Docker // FF

fmontes added a commit that referenced this issue Mar 28, 2023
@jcastro-dotcms @victoralfaro-dotcms
@rjvelazco @alfredo-dotcms @fmontes @manuelrojas @zulqarnainvd @hassan-mustafa-baig @wezell @erickgonzalez @jdotcms
Merging 23 03 to master (#24470)
da2f8b1 
* Update release version for dotcms-ui and dotcms-webcomponents

* Modify dotcmsReleaseVersion to 23.03, coreWebReleaseVersion, webComponentsReleaseVersion to rc and dot-cicd branch version to release-23.03

* Update branch in git submodule to release-23.03

* Excluding from triggering test at folder: dotCMS/src/main/webapp/html

* #23977 Block editor freeze scroll on tippy menus show (#24180)

* dev: freeze scroll on show forms #23977

* clean up

* refactor

* clean up v2

* feedback

* clean up

* #24172 Refresh Page portlet's data when site changed (#24175)

* #24031 fix block editor not saving (#24222)

* Fix #24032 Bring it to 22.03 (#24229)

* Fix #24032 Bring it to 22.03

* Build de lib

---------

Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>

* #24240 Fix data-access tests in 23.03 (#24244)

* #24240 fix test cases

* #24240 fix lint

* fire release docker image generation

* #24221 fix Snapshots should be displayed when the language is changed (#24234)

* Fix #23449 show dotAssets in folder listing

* Bock Editor: Allow user to insert videos from local files#23863 (#24248)

* dev: remove fileSize limit and fit the video in the block editor #23863

* clean up

* Fix 24032: Adding for Internal QA (#24255)

* #24032 Adding Fix for Internal QA

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Adding PR Feedback

* #24032 Logging error

* dotCMS/core#issue-20432 adding const

* dotCMS/core#issue-20432 adding const

* #24032 validation schema

* Adding empty extensions

* Adding empty extensions

* Get all modules no actions required

* Adding optional validation for actions

* Adding optional validation for actions

* Adding id insted of name

* Adding Type for promise

* Adding dot-cms-block-editor

* Adding lock file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #22151 make the message better (#24041)

* #22151 make the message better

* #22151 hides token button if aws

* #24173 Create dialog for 'Create Page' button (#24215)

* #24173 Create dialog for 'Create Page' button

* #24173 Create dialog for 'Create Page' button - tests

* #24173 Create dialog for 'Create Page' button - feedback

* #24173 Create dialog for 'Create Page' button - more feedback

* #23901 fixes the git hash resolution (#23902)

* #23889 fixed content permission load issue (#24296)

* #24308 Can't search for contentlets in edit page palette (#24316)

* #24308 fixed contentlets search

* #24308 refactor test case

* #24308 refactor code

* #24243 fixed squash between hint icon  and label (#24298)

* dev: update block editor (#24323)

* [Issue-23863]: Fix #23863 Max Dimensions for Videos and Images (#24338)

* #23863 adding fix for max dimensions

* Adding editor

* Fix label

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* mockPrintWriter (#24352)

* #24263 prevent empty save block editor field (#24342)

* Fix #24230 Block editor markdown content with javascript code is breaking the app (#24359)

* #24230

* #24230  clean up

* #24230 moving logic to the JSP

* [Issue 24370] block editor crashing with allowed blocks (#24375)

* #24370  Fixing undefined this

* #24370  Fixing undefined this

* Fix #23863 block editor allow user to insert videos from local files fix size (#24374)

* dev: prevent close form while uploading asset #23863

* fix: large videos preview

* clean up

* update block editor

* feedback

* dev: update dotcms-block-editor.js file

* Block Editor: Allow users to insert videos from external sources#23861 (#24409)

* dev: validate video url

* dev: add video validation #23861

* clean up

* fix merge conflicts

* update dotcms-block-editor.js

* dev: add support link to unknown errors

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* Update core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-external-asset/utils/index.ts

* update dotcms-block-editor.js

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* Fix #24361 block editor code block should not show suggestions or placeholder (#24403)

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* #24361 Blocking suggestions and placeholder

* build file

---------

Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>

* #24422 fixes render

* Update LTS check

* Fix #23863 let user cancel upload (#24417)

* dev: let user cancel upload #23863

* update dotcms-block-editor.js

* clean up

* feedback

* update dotcms-block-editor.js

* dev: upload automatically after selecting the video

* Fix #24263: get the correct input element for block editor (#24429)

* Fix #23449 Filter does not work on the image selector for image fields 

* Moved code to a new branch

* Fix for the DB query

* Fixed failing ITs also addressed the PR feedback

* Added javadoc

* Fixed the failing test

* Fixed some ITs

* Fix postman tests

* Fixed postman tests

* Addressed PR feedback

* Making sonar happy

* Adding more code changes.

* Removed unnecessary file

* Fixed luceneQuery to fix failing ITs

* Adding `showOnMenu` term to lucene query.

* Updating reindex policy in Integration Test to wait for the ES reindex to be done when saving the test files.

* Adding temporary logging to the Integration Test

* Force indexation.

* Print more info.

* Removing `SYSTEM_HOST` from DB query.

* Fixing Integration Test.

---------

Co-authored-by: Jose Castro <jose.castro@dotcms.com>

* Fix #24299 now the get dependencies do not throw an exception when the story block value is not a json (#24439)

* Bock Editor: Allow user to insert videos from local files #23863 (#24451)

* dev: support video file and dotAsset #23863

* update dotcms-block-editor.js file

* dev: update label to Library and dotcms-block-editor.js file

* Block editor value [Object, object] fix (#24474)

* Updating branch references

* dev: rename video node (#24477)

* dev: restore data mock time (#24478)

* Fix conflict

* Fix lock

* Point to master

* Fix lock

* Fixing merging conflict.

---------

Co-authored-by: victoralfaro-dotcms <victor.alfaro@dotcms.com>
Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
Co-authored-by: alfredo-dotcms <37185433+alfredo-dotcms@users.noreply.github.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Manuel Rojas <manuel.rojas.21@gmail.com>
Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
@wezell wezell closed this as completed May 12, 2023
erickgonzalez added a commit that referenced this issue May 22, 2023
@erickgonzalez
#24422 include in 23.01.3
edaf6e6
@erickgonzalez erickgonzalez added LTS: Excluded Ticket that has been excluded from at least one LTS Release : 23.01.3 Included in LTS patch release 23.01.3 labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.01.3 Included in LTS patch release 23.01.3 Release : 23.03 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fmontes @wezell @bryanboza @erickgonzalez