Merged
Conversation
- Add internal/decoder package with DecodeEnvelope function - Implement FuzzDecodeEnvelope and FuzzDecodeEnvelopeBytes fuzz tests - Add unit tests for error handling validation - Ensure graceful handling of malformed XDR input without panics - Fuzz tests run for 1+ minute with 1M+ executions, zero crashes found
- Create dedicated environment-variables.md with complete variable table - Document ERST_SIMULATOR_PATH with description, defaults, and examples - Add categorization by function (Simulator) - Include usage examples for Linux/macOS, Windows, and Docker - Document binary search order and fallback behavior - Add reference link in main README - Verify documented variable works as described
- Add .golangci.yml with unused linter configuration - Create lint-unused.sh script for automated unused code detection - Add Makefile with linting targets - Document unused code detection setup in docs/unused-code-detection.md - Configure exclusions for test files and exported APIs Note: Go toolchain version mismatch prevents immediate execution. Linting will be functional once toolchain issue is resolved.
- Add test-unused-detection.sh to verify linter setup - Update Makefile with test-unused target - Provides validation once Go toolchain issue is resolved
- Update go.mod to use Go 1.21 to match CI environment - Add golangci-lint step to CI pipeline with proper action - Simplify golangci-lint config for better CI compatibility - Add validate-ci.sh script to check configuration consistency - Add validate-ci target to Makefile This ensures the unused linter will run successfully in CI/CD.
Documents all changes made to ensure unused linter passes CI/CD tests.
Arome8240
added a commit
to Arome8240/hintents
that referenced
this pull request
Feb 24, 2026
- Add canonical JSON serialization to ensure deterministic hashing - Implement marshalCanonical function with sorted object keys - Update Generate and Verify functions to use canonical JSON - Add comprehensive test suite for canonical JSON behavior - Add cross-platform determinism tests - Add documentation explaining canonical JSON implementation - Add example demonstrating canonical JSON usage - Ensure hash consistency across different OS targets Resolves dotandev#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116 closes