Skip to content
This repository was archived by the owner on Sep 12, 2018. It is now read-only.

Conversation

@noxiouz
Copy link
Contributor

@noxiouz noxiouz commented Oct 15, 2013

We use a Docker in our open-source PaaS Cocaine (https://github.com/cocaine) in Yandex. Also we use Ellptics as storage in our cloud. So I added support Elliptics as backend for docker-registry.

More info about Elliptics: http://doc.reverbrain.com/elliptics:elliptics https://github.com/reverbrain/elliptics

@samalba
Copy link
Contributor

samalba commented Oct 15, 2013

Thanks for the contribution, the code looks good!

Could you fix the small pep8 warning (the Travis test is failing). Also another minor comment, it would make sense to rename lib/storage/ell.py to lib/storage/elliptics.py?

It's great to see such a major contribution coming from the community!

Rename ell.py -> ellipticsbackend.py.
@noxiouz
Copy link
Contributor Author

noxiouz commented Oct 15, 2013

it would make sense to rename lib/storage/ell.py to lib/storage/elliptics.py

Python package for Elliptics has elliptics.py, so I renamed ell.py to ellipticsbackend.py to prevent clashes of names.

Thank you!

@samalba
Copy link
Contributor

samalba commented Oct 17, 2013

LGTM!

cc @shin-, confirmed?

@shin-
Copy link
Contributor

shin- commented Oct 17, 2013

👍 LGTM

samalba added a commit that referenced this pull request Oct 17, 2013
Introduce Elliptics backend for registry.
@samalba samalba merged commit 9d91ff9 into docker-archive:master Oct 17, 2013
@dmp42
Copy link
Contributor

dmp42 commented May 14, 2014

Hi there @noxiouz

We are looking for someone to re-adopt this code. Details in #359.

Best.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants