Skip to content

update cli.md#6790

Merged
fredlf merged 2 commits intomoby:masterfrom
SvenDowideit:pr_out_update_cli_md
Jul 3, 2014
Merged

update cli.md#6790
fredlf merged 2 commits intomoby:masterfrom
SvenDowideit:pr_out_update_cli_md

Conversation

@SvenDowideit
Copy link
Copy Markdown
Contributor

@SvenDowideit SvenDowideit commented Jul 1, 2014

No description provided.

@SvenDowideit SvenDowideit mentioned this pull request Jul 1, 2014
Closed
@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Jul 1, 2014

#6753 has LGTM's from @vieux and @shykes

So far, I've added the updated cli.md, and an initial bash through the man pages.

@jamtur01 @ostezer @fredlf please review the cli change and merge when happy

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Jul 1, 2014

#ipbabble - yes, I've scripted the generation of the OPTIONs texts - As the hand crafted text you made were short, think we should improve the text that is in the docker cli instead.

SvenDowideit
SvenDowideit reviewed Jul 1, 2014
View reviewed changes
docs/man/docker-run.1.md Outdated
Copy link
Copy Markdown
Contributor Author

@SvenDowideit SvenDowideit Jul 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. I need to solve this. tomorrow i think.

@jamtur01
Copy link
Copy Markdown
Contributor

jamtur01 commented Jul 1, 2014

Sorry - puzzled what's happening here? Is this good for review?

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Jul 1, 2014

Yes. Its good. Though I'm assuming I may have missed something, I've been poking holes and fixing them for too many hours so I expect I'm snow blind

On 1 July 2014 23:18:33 GMT+10:00, James Turnbull notifications@github.com wrote:

Sorry - puzzled what's happening here? Is this good for review?

Reply to this email directly or view it on GitHub:
#6790 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@jamtur01
Copy link
Copy Markdown
Contributor

jamtur01 commented Jul 1, 2014

Why the "ouch"?

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Jul 1, 2014 

+[**-**|**--publish-all**[=*false*]]

is missing a P

This was referenced Jul 1, 2014
Merged
Merged
@jamtur01
Copy link
Copy Markdown
Contributor

jamtur01 commented Jul 2, 2014

LGTM

@jamtur01
Copy link
Copy Markdown
Contributor

jamtur01 commented Jul 2, 2014

Ping @ostezer @fredlf

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Jul 3, 2014

@ostezer @fredlf

jamtur01 and others added 2 commits July 3, 2014 10:22
@jamtur01 @SvenDowideit
Fixed numerous inconsistencies in command help text
b59754b 
* Replaced docker with Docker.
* Consistently used STDIN, STDOUT, STDERR.
* Consistently used TTY.
* Fixed some grammar and spelling issues.
* Fixed references to the index.

Docker-DCO-1.1-Signed-off-by: James Turnbull <james@lovedthanlost.net> (github: jamtur01)

Docker-DCO-1.1-Signed-off-by: James Turnbull <james@lovedthanlost.net> (github: SvenDowideit)
@SvenDowideit
Update cli.md and man pages to match current cli
b07f193 
Docker-DCO-1.1-Signed-off-by: SvenDowideit <SvenDowideit@home.org.au> (github: SvenDowideit)
@fredlf
Copy link
Copy Markdown
Contributor

fredlf commented Jul 3, 2014

LGTM

fredlf pushed a commit that referenced this pull request Jul 3, 2014
Merge pull request #6790 from SvenDowideit/pr_out_update_cli_md
2c32c19 
update cli.md
@fredlf fredlf merged commit 2c32c19 into moby:master Jul 3, 2014
@SvenDowideit SvenDowideit deleted the pr_out_update_cli_md branch January 28, 2015 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SvenDowideit @jamtur01 @fredlf