Skip to content

πŸͺ² BUG-#205: Fix PR #202 review issues β€” duration, executor leak, checkpoint, docstring#222

Merged
FernandoCelmer merged 3 commits intodevelopfrom
feature/205
Apr 8, 2026
Merged

πŸͺ² BUG-#205: Fix PR #202 review issues β€” duration, executor leak, checkpoint, docstring#222
FernandoCelmer merged 3 commits intodevelopfrom
feature/205

Conversation

@FernandoCelmer
Copy link
Copy Markdown
Member

Description

Fixes all issues raised in PR #202 code review.

Issue: πŸ“Œ ISSUE-#205

Changes

  • Duration in finally β€” task.duration now calculated in finally block, always available for tracer (was only set on success)
  • Executor leak β€” _execute_with_timeout uses finally for executor.shutdown() (was missing on success path)
  • Class error detection β€” _is_class_internal_error checks ExecutionWithClassError type (was only checking message patterns)
  • Single storage query β€” _has_checkpoint + _restore_checkpoint unified into _try_restore_checkpoint (was 2 queries per checkpoint)
  • Action docstring β€” Updated to reflect that retry/timeout are enforced by TaskEngine, not Action

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@FernandoCelmer FernandoCelmer merged commit e237bf1 into develop Apr 8, 2026
10 checks passed
@FernandoCelmer FernandoCelmer deleted the feature/205 branch April 8, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant