Skip to content

🪲 BUG-#235: Fix deploy --platform lambda-scheduled ignoring missing --schedule#236

Merged
FernandoCelmer merged 9 commits intodevelopfrom
feature/235
Apr 9, 2026
Merged

🪲 BUG-#235: Fix deploy --platform lambda-scheduled ignoring missing --schedule#236
FernandoCelmer merged 9 commits intodevelopfrom
feature/235

Conversation

@FernandoCelmer
Copy link
Copy Markdown
Member

Description

Fix dotflow deploy --platform lambda-scheduled silently deploying without EventBridge trigger when --schedule is not provided.

Issue: 📌 ISSUE-#235

Changes

  • Add ScheduleResolver to deploy.py — reads schedule from --schedule arg, template.yaml, or user input
  • Add AWSSchedule in cloud/aws/schedule.py — converts crontab to EventBridge format, reads SAM templates
  • Organize deployers into deployers/ subfolders (AWS, GCP, GitHub)
  • Move platform constants (PLATFORMS, DEFAULT_REGION, SAM_PLATFORMS, SCHEDULED_PLATFORMS) to provider constants
  • Remove dead code (ensure_roles, ensure_logs no-ops)
  • Add PyYAML to deploy-aws optional dependency
  • Deploy methods now use convention _deploy_{platform_snake_case} — no mapping dict needed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@FernandoCelmer FernandoCelmer added the bug Something isn't working label Apr 9, 2026
@FernandoCelmer FernandoCelmer merged commit a3a27e9 into develop Apr 9, 2026
10 checks passed
@FernandoCelmer FernandoCelmer deleted the feature/235 branch April 9, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant