Skip to content

🪲 BUG-#69: Fix Background mode results unreliable#85

Merged
FernandoCelmer merged 3 commits intodevelopfrom
feature/69
Mar 26, 2026
Merged

🪲 BUG-#69: Fix Background mode results unreliable#85
FernandoCelmer merged 3 commits intodevelopfrom
feature/69

Conversation

@FernandoCelmer
Copy link
Copy Markdown
Member

Description

  • dotflow/core/workflow.py: fixed Background._flow_callback to append task results to the queue (was pass)
  • dotflow/core/workflow.py: fixed Background.get_tasks() to return self.queue instead of self.tasks
  • dotflow/core/workflow.py: fixed Background.run() to execute tasks directly via _run_sequential() instead of delegating to Sequential (which used its own internal callback, bypassing Background's queue entirely)

Motivation and Context

Background mode was silently delegating execution to a Sequential instance, which used its own _flow_callback and never wrote results back to Background's queue. As a result, get_tasks() always returned the original unexecuted task list.

Closes #69

Types of changes

  • Bug fix (change that fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works

@FernandoCelmer FernandoCelmer merged commit d4afca4 into develop Mar 26, 2026
6 checks passed
@FernandoCelmer FernandoCelmer deleted the feature/69 branch March 26, 2026 16:45
@FernandoCelmer FernandoCelmer self-assigned this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Background mode returns before execution completes, making results unreliable

1 participant