docs: add docstring and return type to DotFlow.result()#87
Closed
alexkore12 wants to merge 1 commit intodotflow-io:developfrom
Closed
docs: add docstring and return type to DotFlow.result()#87alexkore12 wants to merge 1 commit intodotflow-io:developfrom
alexkore12 wants to merge 1 commit intodotflow-io:developfrom
Conversation
Add missing docstring to DotFlow.result() method for API consistency with result_task(), result_context(), and result_storage(). Also adds -> dict return type annotation. Closes dotflow-io#83
Member
|
Thanks for the contribution, @alexkore12! 🎉 The docstring addition was already merged via PR #86. Your other PR #94 (execution typo fix) has been merged. Thanks for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #83
Adds the missing docstring to
DotFlow.result()for consistency with the otherresult_*methods.Changes
result()method describing its return value-> dictreturn type annotationBefore
After