AuthenticationAdapter PHPStan error

[Jurj-Bogdan]

Bug Report

Q	A
Version(s)	7.0

Summary

AuthenticationAdapter#L80 triggers an "Unable to resolve the template type T in call to method Doctrine\ORM\EntityManagerInterface::getRepository()" error.

How to reproduce

Running composer static-analysis or PHPStan directly.

[arhimede]

error is stil there ?
see the latest renovate PR run @alexmerlin ?

[alexmerlin]

error is stil there ? see the latest renovate PR run @alexmerlin ?

@arhimede It's because renovate, this "genius", does not automatically update it's own PR with any new modifications.

The fix was added into src/Admin/src/Adapter/AuthenticationAdapter.php on lines 79-82 and it fixed the issue as we can see that all checks are green.

But, on renovate's branch this was not updated.

[arhimede]

error is stil there ? see the latest renovate PR run @alexmerlin ?

@arhimede It's because renovate, this "genius", does not automatically update it's own PR with any new modifications.

The fix was added into src/Admin/src/Adapter/AuthenticationAdapter.php on lines 79-82 and it fixed the issue as we can see that all checks are green.

But, on renovate's branch this was not updated.

then should we merge this pr or Monday will be a good day for that ?

[alexmerlin]

error is stil there ? see the latest renovate PR run @alexmerlin ?

@arhimede It's because renovate, this "genius", does not automatically update it's own PR with any new modifications.
The fix was added into src/Admin/src/Adapter/AuthenticationAdapter.php on lines 79-82 and it fixed the issue as we can see that all checks are green.
But, on renovate's branch this was not updated.

then should we merge this pr or Monday will be a good day for that ?

Sounds good. 👍