Skip to content

Conversation

@alexmerlin
Copy link
Member

Also, IndexHandler -> GetIndexViewHandler
And IndexHandlerFactory -> GetIndexViewHandlerFactory

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin self-assigned this Feb 28, 2025
@alexmerlin alexmerlin linked an issue Feb 28, 2025 that may be closed by this pull request
@alexmerlin alexmerlin requested a review from arhimede February 28, 2025 16:11
@alexmerlin
Copy link
Member Author

Forgot about PageHandler's factory and the handler+factory from the App module. Oops... 👀

@github-actions
Copy link

github-actions bot commented Feb 28, 2025

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 35 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/varexporter 0.5.0 MIT
dotkernel/dot-errorhandler 4.2.1 MIT
dotkernel/dot-log 5.1.0 MIT
fig/http-message-util 1.1.5 MIT
laminas/laminas-component-installer 3.5.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.18.0 BSD-3-Clause
laminas/laminas-diactoros 3.5.0 BSD-3-Clause
laminas/laminas-escaper 2.16.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.11.0 BSD-3-Clause
laminas/laminas-servicemanager 4.4.0 BSD-3-Clause
laminas/laminas-stdlib 3.20.0 BSD-3-Clause
laminas/laminas-stratigility 3.13.0 BSD-3-Clause
laminas/laminas-translator 1.1.0 BSD-3-Clause
laminas/laminas-validator 3.0.1 BSD-3-Clause
mezzio/mezzio-fastroute 3.12.0 BSD-3-Clause
mezzio/mezzio-helpers 5.17.0 BSD-3-Clause
mezzio/mezzio-router 3.18.0 BSD-3-Clause
mezzio/mezzio-template 2.11.0 BSD-3-Clause
mezzio/mezzio-twigrenderer 2.17.0 BSD-3-Clause
mezzio/mezzio 3.20.1 BSD-3-Clause
nikic/fast-route v1.3.0 BSD-3-Clause
nikic/php-parser v5.4.0 BSD-3-Clause
psr/container 2.0.2 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 2.0 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/log 3.0.2 MIT
symfony/deprecation-contracts v3.5.1 MIT
symfony/polyfill-ctype v1.31.0 MIT
symfony/polyfill-mbstring v1.31.0 MIT
twig/twig v3.20.0 BSD-3-Clause
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 1.11.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@arhimede
Copy link
Member

hah, after i implemented previous PR into dotkernel.org

We may need a drawing, a scheme with the flow and the naming convention, to be albe to follow it moving forward
@alexmerlin

@arhimede arhimede merged commit 0611124 into 1.0 Mar 3, 2025
33 checks passed
@alexmerlin alexmerlin deleted the issue-46 branch March 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename PageHandlerFactory to GetPageViewHandlerFactory

3 participants