-
Notifications
You must be signed in to change notification settings - Fork 293
Strict Liquid Syntax (Part 2) + Render Performance #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance (based on Fluid's benchmark) vs latest NuGet |
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 85.07% 86.73% +1.66%
==========================================
Files 61 62 +1
Lines 2452 2511 +59
Branches 670 599 -71
==========================================
+ Hits 2086 2178 +92
+ Misses 223 213 -10
+ Partials 143 120 -23
Continue to review full report at Codecov.
|
|
Here is an updated benchmark, accounting for the differences in behavior between DotLiquid 2.1 and 2.2 Summary: 2.2 gives a 10% edge over 2.1 on render and on parse operations. Overall, rendering can be 65% - 80% faster when utilizing all the performance tweaks. |
|
I'm trying to use inline suggestion for minor/cosmetic changes so you can just click on the accept button. Approved to merge with only these minor comments. |
This improves upon render time with a slew of under the hood changes. Notable changes:
For all versions:
With an opt-in flag for DotLiquid 2.2 Syntax
It remains unknown how much this impacts the benchmarks on RicoSuter/NJsonSchema#1346 ... would love to hear from that team