Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@BillWagner
Copy link
Collaborator

The basic catalog.webforms application runs on the fake data service.
The draft of the section is included as a word doc.

Remaining tasks:

  1. Build the docker-compose file to create the sql server windows image, the catalog service windows images and the web froms application.
  2. Write the small section describing that compose file.
  3. Update the styles for the main image.

@CESARDELATORRE Can you review the word doc?

The default for this app is
'Microsoft.eShopOnContainers.Catalog.WebForms'
Tried to get all the services launched via Visual Studio.  After adding
the SQL engine and catalog container, it failed.
@eiximenis eiximenis merged commit ddcb085 into dotnet-architecture:master Mar 3, 2017
@eiximenis
Copy link
Contributor

Merged into master

@BillWagner
Copy link
Collaborator Author

@eiximenis I have used the WIP acronym on PRs for "work in progress", which isn't ready to merge yet.

What is the convention we're using on this repo? /cc @CESARDELATORRE

Note: this one is safe, in that the only project affected is the web forms app. It's not working correctly yet in Docker with the catalog service.

@eiximenis
Copy link
Contributor

Hi @BillWagner.
My fault, didn't know this convention. For me is ok to use it.
I reviewed the files and saw only files for the webforms app, and i assumed it was ready.

As said, ok to follow this convention ;)
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants