Update Kestrel configuration sections#10344
Merged
Conversation
guardrex
force-pushed
the
guardrex/kestrel-config
branch
from
cd159d8 to
734564e
Compare
Update date Change section heading
guardrex
force-pushed
the
guardrex/kestrel-config
branch
from
3850c84 to
52b50b0
Compare
jkotalik
reviewed
Jan 11, 2019
| }); | ||
| ``` | ||
|
|
||
| If the app doesn't call `CreateDefaultBuilder`, call <xref:Microsoft.AspNetCore.Hosting.WebHostBuilderKestrelExtensions.UseKestrel*> **before** calling `ConfigureKestrel`: |
Contributor
There was a problem hiding this comment.
I don't think you need a code sample. I think just saying:
If the app doesn't call CreateDefaultBuilder, UseKestrel xref:Microsoft.AspNetCore.Hosting.WebHostBuilderKestrelExtensions.UseKestrel* still needs to be called, and should be before calling ConfigureKestrel.
Collaborator
Author
There was a problem hiding this comment.
don't think
I picture code sample is worth a thousand words. 😄
I'll strike it, of course, if you like. There's no harm tho.
Collaborator
Author
There was a problem hiding this comment.
The current text says what you just said without colloquial language ("still") and avoids the state verb ("be").
jkotalik
approved these changes
Jan 11, 2019
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10343
Including a code sample should help, so I add one to the migration and Kestrel topics. Let me know if you would like to add more detail. This doesn't get into the weeds on why, which might be ok.