Fix ActionResult<T> for consistency#17540
Merged
scottaddie merged 1 commit intodotnet:masterfrom Mar 31, 2020
serpent5:serpent5/#17528
Merged
Fix ActionResult<T> for consistency#17540scottaddie merged 1 commit intodotnet:masterfrom serpent5:serpent5/#17528
scottaddie merged 1 commit intodotnet:masterfrom
serpent5:serpent5/#17528
Conversation
scottaddie
approved these changes
Mar 31, 2020
Member
|
Thank you for the help fixing this, @serpent5! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17528.
Really, this should just be
IActionResult, becauseTodoItemDTOisn't returned from the method. I was gonna do that instead, but the scaffolded code sets things up like this. It really doesn't matter what type is used for the generic here, but usingTodoItemDTOmakes sense, at least.