Skip to content

Update breadcrumb toc.yml to point to new hub page#17559

Merged
wadepickett merged 1 commit intomasterfrom
wade-pickett/breadcrumb-update-3-31-20
Apr 1, 2020
Merged

Update breadcrumb toc.yml to point to new hub page#17559
wadepickett merged 1 commit intomasterfrom
wade-pickett/breadcrumb-update-3-31-20

Conversation

@wadepickett
Copy link
Copy Markdown
Contributor

@wadepickett wadepickett commented Apr 1, 2020

Internal Review - see breadcrumb at top

Updating the breadcrumb/toc.yml so it points to the new hub page instead of the old one.

  • I will remove the old unused hub page in a separate PR once this last reference to it is updated.
  • The ASP.NET 4.x breadcrumb that point to the old hub page will also have to be changed in a separate PR.

@wadepickett wadepickett self-assigned this Apr 1, 2020
@wadepickett wadepickett marked this pull request as ready for review April 1, 2020 01:25
@wadepickett wadepickett merged commit fd00a9a into master Apr 1, 2020
@wadepickett wadepickett deleted the wade-pickett/breadcrumb-update-3-31-20 branch April 1, 2020 01:55
@scottaddie
Copy link
Copy Markdown
Member

I think the breadcrumb trail should go Docs > ASP.NET Core. It doesn't make much sense to me to have Docs > ASP.NET > ASP.NET Core if both ASP.NET and ASP.NET Core point to the same page. Thoughts, @wadepickett & @Rick-Anderson?

@Rick-Anderson
Copy link
Copy Markdown
Contributor

@scottaddie agreed. @wadepickett can you do another PR and fix that?

@wadepickett
Copy link
Copy Markdown
Contributor Author

wadepickett commented Apr 1, 2020

Sorry @scottaddie , I merged a minute before your comment. Given .NET 5, would we instead go to this?

Docs > .NET > ASP.NET Core

".NET" would be the .NET hub page.

I agree on getting rid of the extra "ASP.NET". That never made sense to me.

@scottaddie
Copy link
Copy Markdown
Member

@wadepickett No worries. Sorry I couldn't look at this sooner. I think your proposal could work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants