Conversation
|
@pranavkm can you please review this? Thanks! |
|
@guardrex please expect this to delay till some time next week. |
|
@pranavkm I'm going to go ahead and merge this. Let me know if you'd prefer the LocSample hosted here instead of in your repo until the common sample apps can take on the code. If ur ok with holding it for a short while, I'll ping you when it moves into the common samples and is no longer cross-linked. btw - I'm not aware yet that ASP.NET Core docs samples are moving to the samples repo yet ... the word hasn't been given for our samples AFAIK. |
|
I think we merged this in a little too early. P4 hasn't shipped as yet |
|
It wasn't noted on the issue ... I'll back it out this evening and reset the PR for P4. |
|
Will be tracked by #17808 ... I'll do it this evening and merge to live immediately. |
3 participants
Fixes #17513
Internal Review Topic
We'll be able to do more here later when there's more 🕐. For example, I think we should eventually add example code. For now 🏃😅, I recommend that we use this guidance with the linked engineering sample.