Skip to content

Blazor lifecycle diagram and coverage#19543

Merged
guardrex merged 10 commits intomasterfrom
guardrex/blazor-lifecycle-diagrams
Oct 6, 2020
Merged

Blazor lifecycle diagram and coverage#19543
guardrex merged 10 commits intomasterfrom
guardrex/blazor-lifecycle-diagrams

Conversation

@guardrex
Copy link
Copy Markdown
Collaborator

@guardrex guardrex commented Aug 17, 2020

@danroth27
Copy link
Copy Markdown
Member

@guardrex I think all of the changes you proposed sound good, except the addition of the SetParametersAsync in the first image during the property injection step. I don't think those are really related.

@SteveSandersonMS Component disposal isn't currently included in these diagrams. Other community diagrams that I've seen include it. Should we as well?

I think it's also import that include some mention of how Blazor evaluates whether a child component should be rendered on subsequent renders. High level, if the parameter values can be guaranteed to be the same then the child component won't be rendered. @SteveSandersonMS Do you agree that these details should be included? If yes, could you please provide the specifics?

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 20, 2020

If I'm to perform the updates that I listed (perhaps after you, @SteveSandersonMS, make further updates ☝️), can the PPT be emailed as an attachment to me? I can't access the provided link to that file in our offline discussion.

UPDATE: I have the file. Thanks, Dan!

@guardrex
Copy link
Copy Markdown
Collaborator Author

guardrex commented Aug 24, 2020

@danroth27 ...

  • Does it make sense to place the events (Parent renders, DOM event, and Render) outside of the flow diagrams as shown in the images?
  • Other changes?

If these images look good or I can make one more set of edits after your feedback, let me know how many (or if all) of the attached reviewers need to sign off before I can proceed with merging. 👂

Latest images are on the PR.

@guardrex guardrex merged commit c46bcf2 into master Oct 6, 2020
@guardrex guardrex deleted the guardrex/blazor-lifecycle-diagrams branch October 6, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lifecycle diagram and coverage

2 participants