Add "Models" to no-loc for First Web API#19841
Merged
guardrex merged 1 commit intodotnet:masterfrom Sep 12, 2020
serpent5:patch-1
Merged
Add "Models" to no-loc for First Web API#19841guardrex merged 1 commit intodotnet:masterfrom serpent5:patch-1
guardrex merged 1 commit intodotnet:masterfrom
serpent5:patch-1
Conversation
guardrex
approved these changes
Sep 12, 2020
Collaborator
guardrex
left a comment
guardrex
left a comment
There was a problem hiding this comment.
This is a good pattern to adopt. If we add one-off terms to the ends of the lists for individual topics, it won't interfere with when we need to do a repo-wide find-'n-replace to add a term to beginning of every list. I like IT!™️ 👍
Contributor
Author
|
@guardrex I hadn't considered it like that, but yeah, that's nice. I just added it to the end as detailed in the linked issue, but I like that find-'n-replace thinking. 🔍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19802.