Update hosted-with-identity-server.md#20117
Merged
guardrex merged 2 commits intodotnet:masterfrom Oct 6, 2020
Merged
Conversation
The code identity.RemoveClaim(existingClaim); was throwing an exception that the collection was being altered. When I commented that line of code out everything was fine but claims were not being removed. The modification above creates a separate list so as not to involve the Claims collection on User.Identity.
Collaborator
Collaborator
|
🤔 The code doesn't throw on 3.x, and I was going to fix it for .NET 5 updates ... however ... 🤔 ... let's go ahead with a harmless update to 3.x code in case others try and use this with 5.0 preview. Let's go with @Frankofoedu's solution that just makes a new array from the enumerable. I'll make the modification to this PR for it. |
Collaborator
|
Thanks @chassq 🚀 and @Frankofoedu 🌴. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[EDIT by guardrex to add the fixes]
Fixes #19935
The code identity.RemoveClaim(existingClaim); was throwing an exception that the collection was being altered. When I commented that line of code out everything was fine but claims were not being removed. The modification above creates a separate list so as not to involve the Claims collection on User.Identity.