Blazor WASM security updates for 5.0#20138
Conversation
captainsafia
left a comment
There was a problem hiding this comment.
Pretty solid overall! Left some comments inline about clarifying the scopes that are set.
|
@captainsafia ... Ok ... thx for that ... I wish I would've drilled down a bit more this morning. We now have
I thought that the Client app of a hosted solution would be configured like a standalone app ... at least to avoid this new error for an app that doesn't specify default scopes. That's a wrong guess? I would find out the hard way in the morning anyway ... I'll be working with the hosted scenarios tomorrow. |
|
@captainsafia ... I'll go ahead and merge now so that I can pick up with the next round of updates. If there's more to update from this PR, I'll place the changes on the next one. |
Addresses #19503
Internal Review Topics ... these are the focus topics of this PR ...
... there are some additional updates to other topics, but they can be somewhat bypassed given that they aren't receiving their full updates here today. They will be the focus of additional PRs in the coming days.
You'll see that I've temporarily left the NOTE on If the Azure portal provides the scope URI for the app and the app throws an unhandled exception when it receives a 401 Unauthorized response from the API, .... Let's leave that for now. I need to work on that a bit more before I determine if we can safely version it only for 3.x. I'll probably have an answer on it for tomorrow's PR.
I guessed correctly on issue Questions 1-3, so I didn't need to make changes. I already had some general text for
DefaultAccessTokenScopeswithAdditionalScopesToConsentadded on this PR, but we still don't have anything specific yet. If you want to float some content ... a sentence or two ... or more ... on review, let's do that. Otherwise, we can go with this coverage now, and I can ask for further feedback later on it.If possible, I'd like to get this merged by EOD so that I'm unblocked to pick up with the AAD-based hosted topics in the morning. Idk if we can pull it off, but I hope we can try. Sorry for the rush! 🏃🏃🏃🏃🏃🏃 I don't plan on pinging for additional comments, so I yield to you if you think we should.